-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0.2 -> main] P2P: Resolve on reconnect - Take 2 #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1.0.2] P2P: Resolve on reconnect
greg7mdp
approved these changes
Oct 2, 2024
spoonincode
approved these changes
Oct 2, 2024
Need to take this out of draft and take it otherwise there is no way to merge up from 1.0 properly |
heifner
changed the title
[1.0.2 -> main] P2P: Resolve on reconnect
[1.0.2 -> main] P2P: Resolve on reconnect - Take 2
Oct 2, 2024
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve address on reconnect. (Take 2, See #825)
Instead of:
Now you get:
This takes a different approach than #825. This approach is closer to Leap 4.0 approach to connection lifetime although it does keep the
connections_manager
added in Leap 5.0.Backported to Leap 5.0 via AntelopeIO/leap#2410
Merges
release/1.0
intomain
including #853Resolves #525