Remove fc dynamic_rethrow_exception #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Nov 15, 2024
| @@ -13,7 +13,7 @@ | |||
| (const chain::next_function_variant<call_result>& result) mutable { \ | |||
| if (std::holds_alternative<fc::exception_ptr>(result)) { \ | |||
There was a problem hiding this comment.
Not related to your change, but instead of these std::holds_alternative<. and std::get<>, it would be cleaner to use std::visit with lambdas.
linh2931
approved these changes
Nov 15, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
fc::exception::dynamic_rethrow_exception. To work correctlydynamic_rethrow_exceptionrequires registration viaFC_REGISTER_EXCEPTIONSwhich was never done for any of theeosio::chaindefined exceptions.Since this feature never has worked as expected for
eosio::chaindefined exceptions, remove it to avoid confusion.Resolves #980