Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.4] P2P: Fix peer connections log output #1032

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Nov 14, 2024

Only include peer connections that are currently connected in peer connections count in connection monitor log.

Before
p2p client connections: 0/25, peer connections: 17/17, block producer peers: 0
After
p2p client connections: 0/25, peer connections: 11/17, block producer peers: 0

Resolves #1006

@heifner heifner requested review from greg7mdp and linh2931 November 14, 2024 19:18
@heifner heifner added the OCI Work exclusive to OCI team label Nov 14, 2024
@heifner heifner linked an issue Nov 14, 2024 that may be closed by this pull request
@heifner heifner merged commit 4e0a498 into release/1.0 Nov 18, 2024
36 checks passed
@heifner heifner deleted the GH-1006-p2p-client-count-1.0 branch November 18, 2024 15:51
@ericpassmore
Copy link
Contributor

Note:start
category: Logging
component: P2P
summary: More accurate count of peer connections.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2P: client connections incorrect
4 participants