Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.4 -> main] P2P: Fix sync stuck corner case #1038

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Nov 19, 2024

Update chain_info on accepted_block signal since chain_head has changed. The sync logic needs up to date info of the state of the node. This normally doesn't cause an issue because under normal conditions the node would soon receive a accepted_block_header or irreversible_block signal which would update the net_plugin state.

Merges release/1.0 into main including #1035
Empty diff, main already included change.

Resolves #998

@heifner heifner added the OCI Work exclusive to OCI team label Nov 19, 2024
@heifner heifner requested review from linh2931 and greg7mdp November 19, 2024 12:57
@heifner heifner merged commit 7c54987 into main Nov 19, 2024
36 checks passed
@heifner heifner deleted the GH-998-sync-stuck-main branch November 19, 2024 20:33
@ericpassmore
Copy link
Contributor

Note:start
category: System Stability
component: P2P
summary: Fix sync stuck that can occur with very tight sync-fetch-span.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: nodeos_startup_catchup_if_lr_test
4 participants