[1.0.4 -> main] Merge fix flaky startup catchup test #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han syncFetchSpan
[1.0.4] Fix nodeos_startup_catchup test
…y_startup_catchup_test
greg7mdp
approved these changes
Nov 21, 2024
heifner
approved these changes
Nov 21, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward #1033 with updated pattern of unlinkable blocks on the main branch.
The test on
maincounts the total number ofunlinkable_blockoccurrences in all logging files and checks if it is greater than500or not. This is flaky because when sync fetch span is greater than 500 (default is 1000), temporary unlinkable blocks can be greater than 500.This PR changes to check the number of consecutive unlinkable blocks in each logging file is less than sync fetch span (the worst case).
Resolves #1015