Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Create unique log files for nodeos #1135

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Test: Create unique log files for nodeos #1135

merged 2 commits into from
Jan 29, 2025

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 28, 2025

When nodeos is quickly relaunched in the integration tests, it is possible that a nodeos log file is overwritten because it has the same launch time and file name. This happens, for example, in nodeos_read_terminate_at_block_test.py. Make sure a unique log file name is created for each run of nodeos.

@heifner heifner added this to the Spring v1.1.0-rc1 milestone Jan 28, 2025
@heifner heifner added the OCI Work exclusive to OCI team label Jan 28, 2025
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Ensure unique nodeos log file names when running tests.
Note:end

Copy link
Contributor

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment such as # make sure we don't overwrite an existing log file.

@heifner heifner merged commit 7121d54 into main Jan 29, 2025
36 checks passed
@heifner heifner deleted the unique-log-files branch January 29, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants