Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): New "features" section of the app spec to allow enabling deletes #5898

Merged
merged 3 commits into from
Jan 23, 2025
Merged

feat(operator): New "features" section of the app spec to allow enabling deletes #5898

merged 3 commits into from
Jan 23, 2025

Conversation

EricWittmann
Copy link
Member

Looking for feedback on this. I thought we would probably have more than just this feature, so rather than having the allowDeletes property on the AppSpec I created a features property that can eventually contain feature config.

wdyt?

@EricWittmann
Copy link
Member Author

Also tell me what you think about the EnvironmentVariables class. I was worried about copy/pasting env var strings around in various places, including tests.

@EricWittmann EricWittmann requested a review from jsenko January 23, 2025 12:18
@jsenko
Copy link
Member

jsenko commented Jan 23, 2025

Also tell me what you think about the EnvironmentVariables class. I was worried about copy/pasting env var strings around in various places, including tests.

No issues with that, sounds good.

@EricWittmann EricWittmann merged commit 58606dd into main Jan 23, 2025
11 checks passed
@EricWittmann EricWittmann deleted the feat/operator-allow-deletes branch January 23, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsenko jsenko jsenko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricWittmann @jsenko