shinyproxy user retrival

[arunkodati77]

In a ShinyProxy environment, the logged-in user will be automatically passed as an environmental variable instead of a session variable. Therefore, if the session is null, added an additional condition to check if username exists as an shinyproxy environmental variable using Sys.getenv("SHINYPROXY_USERNAME").

Follow this steps to test in shinyproxy environment:

1. install docker and shinyproxy as mentioned in the official shinyproxy documentation
2. pull the following docker image
   docker pull aruncoolprojects/demotelemetryshinyproxy
3. overwrite the default shinyproxy configuration by creating a new application.yml in the shinyproxy root folder
   Note: In container-volumes: ["<-path-to-your-local-folder>:/root/shiny/data"], Replace <-path-to-your-local-folder> with your local path such that you can see the telemetry logs.

Have you read the Contributing Guidelines?

Issue Fixed # As you can see first line has a username: shinyproxy (he is the user we configured in our application.yml)

Changes description

Clearly and concisely describe what's in this pull request. Include screenshots, if necessary.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 31.33%. Comparing base (67dc7ed) to head (ff68889).

❗ Current head ff68889 differs from pull request most recent head 00f346b. Consider uploading reports for the commit 00f346b to get more accurate results

Files	Patch %	Lines
R/telemetry.R	0.00%	5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   31.40%   31.33%   -0.07%     
==========================================
  Files          16       16              
  Lines        1433     1436       +3     
==========================================
  Hits          450      450              
- Misses        983      986       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[averissimo]

Thanks for the PR @arunkodati77!

• Can you please add instructions on how to test on a shinyproxy environment? docker-compose.yml or Dockerfile
• Please correct the linter errors as well

[averissimo]

Thanks for the instructions. I was able to setup an instance with the application.yml below

👍 It also works out-of-the-box when authentication: none as it generates a random username hash

application.yml contents

proxy:
  title: Open Analytics Shiny Proxy
  logo-url: https://www.openanalytics.eu/shinyproxy/logo.png
  landing-page: /
  heartbeat-rate: 10000
  heartbeat-timeout: 60000
  port: 8080
  authentication: simple
  admin-groups: scientists
  users:
    - name: shinyproxy
      password: 123
      groups: scientists
    - name: yada
      password: 123
      groups: scientists
  specs:
    - id: demo
      display-name: Demo telemetry
      description: To test
      container-volumes: ["/path/to/valid/folder:/root/shiny/data"]
      container-image: aruncoolprojects/demotelemetryshinyproxy
      access-groups: [scientists]
      
logging:
  file:
    name: shinyproxy.log

I think there's a problem with the code as it will always return "" when not deployed in shinyproxy.io

[averissimo]

LGTM!! 🚀

Forgot about NEWS file

[averissimo]

It looks good, can you add a bullet point item to the NEWS.md files? (under "New Features")

[averissimo]

Looks great! 🚀