Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#174 add mongodb support #176

Merged
merged 16 commits into from
Jun 17, 2024
Merged

Conversation

WahiduzzamanKhan
Copy link
Contributor

@WahiduzzamanKhan WahiduzzamanKhan commented May 6, 2024

Closes #174

Changes description

  • Added support for MongoDB as a data storage backend (see data-storage-mongodb.R)
  • Added example app for MongoDB
  • Created automated tests for DataStorageMongoDB class

Definition of done

  • Have you read the Contributing Guidelines?
  • NEWS.md file has been updated
  • Development version has been bumped (x.y.z.90XX)
  • Issue has been linked with this PR (via Closing keywords or right sidebar under Development)

@averissimo averissimo self-assigned this Jun 6, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good boilerplate code for Mongo, but this PR is not ready for merge. It has a bunch of issues described below.

I'll be fixing them on a separate PR and merge against this one :-)

Non-exaustive list:

  • Documentation
    • With references to MariaDB
    • Parameters for constructor are incorrect (using inexisting parameter called url)
    • Examples are failing
  • Functionality
    • Read doesn't work if only integers were written
    • Read doesn't work for sequential arrays (returns "1:10" string instead of [1,2,3,4,5,6,7,8,9])
  • Automated tests fail
    • When setting up docker container and running
    • Collection paramaeter
Sys.setenv(
    TEST_MONGODB_USER = "root",
    TEST_MONGODB_PASSWORD = "example",
    TEST_MONGODB_HOSTNAME = "localhost",
    TEST_MONGODB_PORT = 27017,
    
    TEST_MONGODB_DBNAME = "shiny_telemetry",
    TEST_MONGODB_COLLECTION = "event_log"
)
devtools::test()

@averissimo averissimo merged commit a7674af into main Jun 17, 2024
8 checks passed
@averissimo averissimo deleted the feature/#174-add-mongodb-support branch June 17, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support MongoDB as backend
2 participants