Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

194 feature support multiple application in analytics app #195

Merged

Conversation

Gotfrid
Copy link
Member

@Gotfrid Gotfrid commented Dec 12, 2024

Closes #194

Changes description

This PR introduces the UI and server changes to be able to switch between multiple application logs. If there is only one application, it should not be a problem: the dropdown will have only one choice.

I thought about the alternative idea to have multiple apps at once, but I think it would blow the scope of this issue too much, since it would require careful considerations for how the plots are aggregated.

As a side-track bonus, I have added devcontainer configuration that installs all required packages and allows the developer to work either in VS Code or in RStudio. You can even run docker-compose inside this docker container.

How to test

You can test it the way you are used to, but the way I do it with the devcontainer:

  • open the folder in vscode, then reopen in devcontainer
  • wait for all processes to complete (takes some time)
  • then start the telemetry database with
cd inst/examples/postgres
docker-compose up
  • then start r session by running ctrl+shift+p -> attach active r terminal
  • in the R console
devtools::load_all()
shiny::shinyAppFile(system.file("examples", "postgresql", "postgres_app.R", package = "shiny.telemetry"))
  • then edit the postgres_app.R to feature a different app_name, and repeat the previous step
  • finally run the postgres analytics app in a similar way to see the result

This is what I'm able to see:
CleanShot 2024-12-12 at 19 30 58

Definition of done

  • Have you read the Contributing Guidelines?
  • NEWS.md file has been updated
  • Development version has been bumped (x.y.z.90XX)
  • Issue has been linked with this PR (via Closing keywords or right sidebar under Development)

@Gotfrid Gotfrid linked an issue Dec 12, 2024 that may be closed by this pull request
1 task
@Gotfrid Gotfrid requested a review from averissimo December 12, 2024 19:34
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!! 💯

Please use dplyr pipe operator as the package doesn't depend on R >= 4.1

R/prepare-admin-panel.R Outdated Show resolved Hide resolved
R/prepare-admin-panel.R Outdated Show resolved Hide resolved
R/prepare-admin-panel.R Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
@Gotfrid Gotfrid requested a review from averissimo December 13, 2024 13:08
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome addition!!

Thanks @Gotfrid 🥳

@Gotfrid Gotfrid merged commit 35dfc39 into main Dec 13, 2024
9 checks passed
@Gotfrid Gotfrid deleted the 194-feature-support-multiple-application-in-analytics-app branch December 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support multiple application in analytics app
2 participants