-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
194 feature support multiple application in analytics app #195
Merged
Gotfrid
merged 11 commits into
main
from
194-feature-support-multiple-application-in-analytics-app
Dec 13, 2024
Merged
194 feature support multiple application in analytics app #195
Gotfrid
merged 11 commits into
main
from
194-feature-support-multiple-application-in-analytics-app
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
averissimo
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!! 💯
Please use dplyr
pipe operator as the package doesn't depend on R >= 4.1
Co-authored-by: André Veríssimo <[email protected]>
Co-authored-by: André Veríssimo <[email protected]>
averissimo
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome addition!!
Thanks @Gotfrid 🥳
Gotfrid
deleted the
194-feature-support-multiple-application-in-analytics-app
branch
December 13, 2024 13:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #194
Changes description
This PR introduces the UI and server changes to be able to switch between multiple application logs. If there is only one application, it should not be a problem: the dropdown will have only one choice.
I thought about the alternative idea to have multiple apps at once, but I think it would blow the scope of this issue too much, since it would require careful considerations for how the plots are aggregated.
As a side-track bonus, I have added devcontainer configuration that installs all required packages and allows the developer to work either in VS Code or in RStudio. You can even run docker-compose inside this docker container.
How to test
You can test it the way you are used to, but the way I do it with the devcontainer:
cd inst/examples/postgres docker-compose up
This is what I'm able to see:
Definition of done
NEWS.md
file has been updatedx.y.z.90XX
)Development
)