Code Coverage + fix SoilIndexedDictionary>>#removeKey:ifAbsent: #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove #ifAbsent: case for the iterator. The iterator by constructin will have the key - SoilIndexedDictionary>> #do: We do not check in any other method for isObjectId in case of no transaction, we can remove it here, too. - add a test for do: for indexed dict without transaction
…up in Object>>#at:) - add failing test testRemoveKeyIfAbsentWithTransaction - make sure to evaluate the absent block in SoilIndexedDictionary>>#removeKey:ifAbsent: instead of raising an Error
MarcusDenker
changed the title
noha
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a version of #at: to #SoilIndexIterator (to not by mistake end up in Object>>#at:)
add failing test testRemoveKeyIfAbsentWithTransaction
make sure to evaluate the absent block in SoilIndexedDictionary>>#removeKey:ifAbsent: instead of raising an Error
SoilIndexedDictionary>> #do:
We do not check in any other method for isObjectId in case of no transaction, we can remove it here, too.