SoilIndexedDictionary: implement size to restore values #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s can restore values correctly on the level of the SoilIndexedDictionary. fixes #527
MarcusDenker
changed the title
noha
reviewed
Dec 8, 2023
| "We should just call size on index, but the do: here can restore values" | ||
| | sum | | ||
| sum := 0. | ||
| self do: [ :each | sum := sum + 1 ]. |
There was a problem hiding this comment.
this does not scale at all. Not sure how we do it until now but doing a linear scan counting is not the way to go
There was a problem hiding this comment.
But we do already do the same linear scam on the index...
There was a problem hiding this comment.
SoilBasicSkipList>>#size
"We iterate over all elements to get the size. Slow!"
^ self newIterator size
There was a problem hiding this comment.
There was already #226, I updated it.
noha
approved these changes
Dec 8, 2023
MarcusDenker
deleted the
527-SoilIndexedDictionarysize-and-restored-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses the #do of the SoilIndexedDictionary in size, this way it is can restore values correctly on the level of the SoilIndexedDictionary.
fixes #527