Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move value restore from the SoilIndexedDictionary to SoilIndexIterator #548

Closed
wants to merge 2 commits into from
Closed

move value restore from the SoilIndexedDictionary to SoilIndexIterator #548

wants to merge 2 commits into from

Conversation

MarcusDenker
Copy link
Contributor

fixes #545

@MarcusDenker MarcusDenker requested a review from noha December 14, 2023 16:38
@MarcusDenker
Copy link
Contributor Author

This moves the restore value code to SoilIndexIterator as #restoreValue:forKey.

As before, it is called in do:, at:ifAbsent: and isEmpty, but not yet in #nextAssociation

TODO

  • instead of calling in in do, we need to do call it in nextAssociation instead.
  • check user of nextPresent and nextPresentAssociation

@MarcusDenker MarcusDenker deleted the Iterator-RestoreValues branch January 17, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noha noha Awaiting requested review from noha

Assignees
No one assigned
Labels
None yet
Projects
Soil project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move handling of restored values to SoilIndexIterator
1 participant
@MarcusDenker