Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

568-Index-Iterator-lastAssociation-need-to-restore-values #580

Merged
merged 1 commit into from
Jan 24, 2024
Merged

568-Index-Iterator-lastAssociation-need-to-restore-values #580

merged 1 commit into from
Jan 24, 2024

Conversation

MarcusDenker
Copy link
Contributor

This PR fixes #lastAssociation

  • restore the value correctly if it was removed in another transaction
  • implement and use #priorAssociation, which will iterate backwards and correctly go to the prior page if needed

fixes #568 and #478

@MarcusDenker
This PR fixes #lastAssociation
cf2bdfa 
- restore the value correctly if it was removed in another transaction
- implement and use #priorAssociation, which will iterate backwards and correctly go to the prior page if needed 

fixes #568 and #478
@MarcusDenker MarcusDenker requested a review from noha January 22, 2024 10:15
@MarcusDenker MarcusDenker linked an issue Jan 22, 2024 that may be closed by this pull request
SoilIndexIterator>>#lastAssociation needs to go to the page before if needed #478
Closed
@noha noha merged commit f397cdc into main Jan 24, 2024
2 checks passed
@MarcusDenker MarcusDenker deleted the 568-Index-Iterator-lastAssociation-need-to-restore-values branch January 24, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noha noha noha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Soil project board
Archived in project
Milestone
No milestone
2 participants
@MarcusDenker @noha