move the key conversion (asIndexKeyOfSize:) to the iterator #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoilIndexIterator>>#find:ifAbsent: now does the convertion - This allows us to remove is from #find: and the parametor of find: in #removeKey:ifAbsent: in the index. - #find: is now in sync between the index and the iterator (taking key, not binKey). The PR changes most of the tests in SoilIndexedDictionaryTest to not use integer keys, as this can hide bugs. (there are some not yet changed, the ones for nextAssociation/lastAssociation and testNextKeyCloseToWithTransaction, that will be another PR as there the change seems to show another bug
noha
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoilIndexIterator>>#find:ifAbsent: now does the convertion
The PR changes most of the tests in SoilIndexedDictionaryTest to not use integer keys, as this can hide bugs.
(there are some not yet changed, the ones for nextAssociation/lastAssociation and testNextKeyCloseToWithTransaction, that will be another PR as there the change seems to show another bug