Filter threshold bug fix #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for bringing this up and debugging it! I'll review the PR and merge it ASAP. |
abearab
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR (#94), we introduced explicit arguments for
count_filter_thresholdandcount_filter_typeincalculateDrugScreen.However, this PR only passed the arguments to the rho calculation and not to the gamma or tau calculations. This introduced a problem: if
count_filter_thresholdandcount_filter_typewere explicitly specified, they would be passed into the rho calculation but not gamma or tau, which would continue to use the defaults.This PR fixes that problem by passing them in correctly.