Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArkOrderbook smart contract : Implement asset ownership verification #290

Closed
ybensacq opened this issue Feb 16, 2024 · 0 comments · Fixed by #312
Closed

ArkOrderbook smart contract : Implement asset ownership verification #290

ybensacq opened this issue Feb 16, 2024 · 0 comments · Fixed by #312
Assignees

Comments

@ybensacq
Copy link
Contributor

ybensacq commented Feb 16, 2024

Is this feature related to a problem? Please describe.
The main goal is to ensure the verification of asset ownership before sending transaction to L2.
If the ownership verification is successful, the message will be sent accordingly.
However, if the verification fails, the state of the smart contract will be updated to "placed".

Describe the solution you'd like
We need to update this method verify_tx_for_starknet in solis crate.

@ybensacq ybensacq changed the title ArkOrderbook smart conrtract : Implement Asset Ownership Verification ArkOrderbook smart contract : Implement asset ownership verification Feb 16, 2024
@ybensacq ybensacq self-assigned this Mar 6, 2024
@ybensacq ybensacq linked a pull request Mar 8, 2024 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant