Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solis): smart contract implement asset ownership verification #312

Conversation

ybensacq
Copy link
Contributor

@ybensacq ybensacq commented Mar 8, 2024

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature (feat:)
  • πŸ› Bug Fix (fix:)
  • πŸ“ Documentation Update (docs:)
  • 🎨 Style (style:)
  • πŸ§‘β€πŸ’» Code Refactor (refactor:)
  • πŸ”₯ Performance Improvements (perf:)
  • βœ… Test (test:)
  • πŸ€– Build (build:)
  • πŸ” CI (ci:)
  • πŸ“¦ Chore (chore:)
  • ⏩ Revert (revert:)
  • πŸš€ Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ Documentation
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

  • Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
  • Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
  • Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

@ybensacq ybensacq requested a review from kwiss March 8, 2024 09:50
@ybensacq ybensacq linked an issue Mar 8, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: 15cded2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ark-project-sdk-demo βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 13, 2024 7:58am

@ybensacq ybensacq changed the base branch from main to 245-fix-core-sdk-tests-for-each-case March 8, 2024 09:51
@ybensacq ybensacq force-pushed the 245-fix-core-sdk-tests-for-each-case branch 2 times, most recently from 39af674 to e85b414 Compare March 8, 2024 14:48
Base automatically changed from 245-fix-core-sdk-tests-for-each-case to main March 12, 2024 15:06
@ybensacq ybensacq force-pushed the 290-arkorderbook-smart-contract-implement-asset-ownership-verification branch from d1af386 to cce44ba Compare March 13, 2024 07:56
@ybensacq ybensacq force-pushed the 290-arkorderbook-smart-contract-implement-asset-ownership-verification branch from cce44ba to 15cded2 Compare March 13, 2024 07:56
@kwiss kwiss merged commit 01a008d into main Mar 13, 2024
8 checks passed
@kwiss kwiss deleted the 290-arkorderbook-smart-contract-implement-asset-ownership-verification branch March 13, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArkOrderbook smart contract : Implement asset ownership verification
2 participants