fix: don't deadlock the runtime when fetching MSK auth token #803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous code introduced a deadlock on the main tokio runtime (joining a thread that was running a blocking call on the runtime).
the only solution I found to this was to create a new temporary tokio runtime so that we can run the async aws code inside the mandatory non-async function. this function is only called when a kafka client using MSK auth needs to fetch a new oauth token, so it should be pretty infrequent.