-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #235
Spelling #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most corrections were automatically suggested by Google Sheets. All fault is mine.
If certain files come from upstreams, I can try to send patches to them as well (although I have a long list, so there's no particular time guarantee for such activity), and I can certainly easily drop any particular files...
@@ -7,7 +7,7 @@ | |||
DebuggerState = Struct( | |||
"panic_options" / Hex(Int64ul), | |||
"current_op" / Hex(Int32ul), | |||
"proceed_on_sync_failre" / Int32ul, | |||
"proceed_on_sync_failure" / Int32ul, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't possible to squash all commits into one, like style? |
codespell only handles common mistakes. check-spelling covers misspellings in general. I'm happy to squash, but only once people are happy w/ the changes. Often people object to some set of my changes. |
D400 = Callback(void, "get_property", obj=FourCC, key=string(0x40), value=OutPtr(Bytes(0x200)), lenght=InOutPtr(uint)) | ||
D400 = Callback(void, "get_property", obj=FourCC, key=string(0x40), value=OutPtr(Bytes(0x200)), length=InOutPtr(uint)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argument change
I think this is fine to merge, but can you fix the conflicts? |
06224ed
to
88b1866
Compare
f0edbd9
to
50c808d
Compare
Rebased, fixed the conflicts, and squashed. Just one more thing though, can you change the commit author / signoff to a real email instead of the weird github noreply thing? If you tell me what email to use (and consent) I can do it for you too. Thanks :) |
|
Correct misspellings identified by the check-spelling action. Signed-off-by: Josh Soref <[email protected]>
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@6e02e3c#commitcomment-79066923
The action reports that the changes in this PR would make it happy: jsoref@2110bdd
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.