Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add contact phone number #59

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: Add contact phone number #59

merged 2 commits into from
Oct 23, 2024

Conversation

jorelosorio
Copy link
Member

Add a new field contact_phone_number as a requirement for AtB-AS/mittatb-app#4756

gorandalum
gorandalum reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@gorandalum gorandalum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be required if no phone number signals that there should be no "Call customerservice" button?

@jorelosorio
Copy link
Member Author

Should it be required if no phone number signals that there should be no "Call customerservice" button?

I changed it to optional.

@jorelosorio jorelosorio mentioned this pull request Oct 23, 2024
Merged
@jorelosorio jorelosorio merged commit 560513e into main Oct 23, 2024
1 check passed
@jorelosorio jorelosorio deleted the jorelosorio/add_contact_phone_number branch October 23, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorandalum gorandalum gorandalum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorelosorio @gorandalum