merge #13
Merged
merge #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referenced commit(s): 4ae69cf
…zerothcore#18907) add quality colors to .item lookup command
Referenced commit(s): 49e3d5d
… lines to supp… (azerothcore#18917) * (DB/SQL)add missing broadcastID to Elder Clearwater txt lines to support localization * Update kaluac.sql
Referenced commit(s): 64833d9
Referenced commit(s): cf8c155
* Init. * Remove auxiliary comments. * Readd comments along with original reward values. * Remove auxiliary comments again. * Add important commit regarding data accuracy. * Move comment.
Referenced commit(s): 346456f
…l when talking to Bran (azerothcore#18927) load Mimiron's and Thorim's Targetting crystal
azerothcore#18928) fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enrage/outro
Referenced commit(s): 0aaf521
…8933) * fix movement of doomfire * fix air burst * conditions * movechase random target * Update boss_archimonde.cpp * update movement * Update boss_archimonde.cpp * Update boss_archimonde.cpp
Referenced commit(s): f78820e
…isting BGs are full. Improve log (cherry picked from commit 86c6c26bba6725336c3742e7ba2285e782b32a4d) # Conflicts: # src/server/game/AI/NpcBots/botdatamgr.cpp # src/server/game/Battlegrounds/Battleground.cpp
AthenaSui
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Janalai (#13) * wip * nullcreature * wipppp * first attempt at working state * hatcherai * test * conditions for hatching * some potential fixes * some debuggo * some small fixes * general fixes * Update boss_janalai.cpp * Update boss_janalai.cpp * Update boss_janalai.cpp * more debug * Update boss_janalai.cpp * Update boss_janalai.cpp * Update boss_janalai.cpp * fixed? * Update boss_janalai.cpp * Update boss_janalai.cpp * Update boss_janalai.cpp * remove dumb bomb count it is not needed * Update boss_janalai.cpp * Update boss_janalai.cpp * Update boss_janalai.cpp * other debug * Update boss_janalai.cpp * Update boss_janalai.cpp * Update boss_janalai.cpp * Update boss_janalai.cpp * Update boss_janalai.cpp * remove script for egg * F * Revert "F" This reverts commit 246c66c. * Revert "remove script for egg" This reverts commit b859335. * different spell ids * Update boss_janalai.cpp * Update boss_janalai.cpp * Update boss_janalai.cpp * restore data sets changing this in a different PR, but data is still being set here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.