merge #14
Merged
merge #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(Core/Network): Add Proxy Protocol v2 support. * Fix codestyle and build. * Another codestyle fix. * One more missing include.
* fic(Docs/PR-Template): update discord invite link * Use correct invite URL (grepped from azerothcore.org)
…zerothcore#18872) - Fix typo when loading reference loot templates - Closes azerothcore#18870 Co-authored-by: Jason Mok <[email protected]>
* Init. Co-Authored-By: AnonXS <[email protected]> * Adjust variable spacing. --------- Co-authored-by: AnonXS <[email protected]>
Referenced commit(s): d34f64a
…upon opening (azerothcore#18877) * remove locked status from scarab coffer upon opening * add Scarab Coffer
Referenced commit(s): 9c363bd
…8876) * fixMaraPortal * convert to update statement
Referenced commit(s): c30cafe
…7951) (azerothcore#18850) * Fix some problems * Change the name of the spell
…ce (azerothcore#18849) fix: hitchance should decrease misschance
Referenced commit(s): 45ad5ac
…18843) * WIP maexxna web wrap * add custom summon web wrap * progress * save * something that works * update sql * cleanup script * clean sql * remove orientation from position * fix: cast web wrap on multiple targets * fix: web wraps should not attack * adjust vertical speed to reduce speed if close, avoid ceiling yeet * rename candIt to itr * remove unused wraps2 * style * use event instead of update(diff) * update spell_dbc sql * include player header to fix error: invalid use of incomplete type * include SpellAuraEffects header * fix Effects start at 1 in DBC * fix web wraps attacking * calc distance with hypotf, define vspeed ranges, remove trig webwrap enum * fixup! calc distance with hypotf, define vspeed ranges, remove trig webwrap enum * fix: call target selection with pos 0, use IsPlayer() * add validate * fixup! fix: call target selection with pos 0, use IsPlayer() * remove not needed header * remove empty lines * use registry macro * Revert "remove not needed header" This reverts commit 254717d.
Referenced commit(s): 9af66df
…eux (azerothcore#18807) * fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaumeux * remove blank line * remove four_horsement_consumption SpellScript * update comment
Referenced commit(s): 2c77139
correct first phoenix in p5 should spawn 15 seconds before 2nd gravity lapse
…e 18729) (azerothcore#18866) * fix(DB/Creature): Correct spells order has been restored for Broken-down Shredder * Update fix_issue18729.sql --------- Co-authored-by: Dan <[email protected]>
…nt (14364)".... (azerothcore#18880) * Increases the number of players who look at the last completed character every 15 seconds. * fix error * fix error * fix error * Update rev_1715337495584103500.sql fix error * update spawn masks --------- Co-authored-by: Dan <[email protected]>
Referenced commit(s): 6b5ad72
* Updating Creature. * Delete data/sql/updates/pending_db_world/rev_1713104748708628400.sql * Updating Bomber
* init sql file for fireworks spectacular - add entry in game_event * add missing delete statement * add gameobjects 180698 'Party Table, 180699 'Festive Keg, 180700 'Hay Bale 1' * update comment, add gameobject 180754 Toasting Goblet - todo: pooling (?) - the tables are quite full - todo: why are there tables missing? e.g. below: .go ga 82615 * add gameobject 180905 'Festive Mug' * add gameobjects 'Firework, Show, Type%' * add vendors * add revelers and bruisers TODO: also add 15906 'Ironforge Reveler' * remove '%Firework Show%' spawns - these will be spawned temporarily via script * add firework gameobject SmartAI * WIP stormwind fireworks show steps to test the show: .go xyz -8984 498 96 0 .gob add temp 180749 * improve handling of fireworks show, add gameobject 180749 'Cheer Speaker' spawns how to test: .go ga 64640 .event start 72 * prepare fetching correct show based on map+zone * introduce typedef for FireworkShow * Add Teldrassil show .go ga 64651 .event start 72 * fix Teldrassil and Stormwind shows, add initShow() debug message, replace magic numbers for fireworkShow sizes - these were broken due to an error in my txt parsing script * add Shattrath show .go c 139914 .event start 72 * add Silvermoon show .go ga 64670 .event start 72 * add Booty Bay show .go ga 64630 .event start 72 * add Thunder Bluff show, add Exodar show, set firework gameobjects active, update comments, remove _maxCount * add Underciy show .go ga 64641 .event start 72 * fix Undercity show indexes * move code from midsummer.cpp to new file firework_show.cpp * add Orgrimmar show .go ga 64647 .event start 72 * add Ironforge show .go ga 64634 .event start 72 * update shows from sniff parses using fixed export script * update 'Party Table, 'Festive Keg' and 'Hay Bale 1' spawns with additional sniffs * update 'Toasting Goblet' spawns with additional sniffs * update 'Festive Mug' spawns with additional sniffs * update 'Fireworks Revelers' spawns with additional sniffs * remove duplicate AND from sql file * attempt moving FireworkShows to the heap * start firework show at the full hour and also handle late starts correctly - also perform a minor cleanup * do not touch gameobject with guid 16586 which is linked to harvest festival * move firework_show.cpp to subfolder firework_show * move firework_show arrays to seperate header files * update show handling, still not final * update for new struct design, Teldrassil show running correctly already * update remaining shows for new firework show structs * rename go_cheer_speaker to go_firework_show * update debug / error messages * update all firework shows for local spawnIndex handling * spawn 'Toasting Goblet's for 10min after show ende * add reveler SAI and make revelers cheer on show end * remove log_error messages * add comment for festive mugs * Update firework_show.cpp * add missing include for uint32 * replace an uint32 with an int * revert unintended changes in midsummer.cpp * add #include "GameObjectScript.h" * remove ThunderBluff Reveler spawns with wandering movement - these probably should have waypoints instead or just got parsed incorrectly - it should be safe to remove these for now and probably investigage this further later on * update function names
Referenced commit(s): 0f82c8e
…erothcore#18844) fix naxxramas portal hub trigger
…e#18890) add unkillable during flight phase _flying: takeoff/landing, moving to location Phase 2: in the air and casting air spells
* init * Update archimondo.sql
Referenced commit(s): 5668e47
…zerothcore#18907) add quality colors to .item lookup command
Referenced commit(s): 49e3d5d
… lines to supp… (azerothcore#18917) * (DB/SQL)add missing broadcastID to Elder Clearwater txt lines to support localization * Update kaluac.sql
Referenced commit(s): 64833d9
Referenced commit(s): cf8c155
* Init. * Remove auxiliary comments. * Readd comments along with original reward values. * Remove auxiliary comments again. * Add important commit regarding data accuracy. * Move comment.
Referenced commit(s): 346456f
…l when talking to Bran (azerothcore#18927) load Mimiron's and Thorim's Targetting crystal
azerothcore#18928) fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enrage/outro
Referenced commit(s): 0aaf521
…8933) * fix movement of doomfire * fix air burst * conditions * movechase random target * Update boss_archimonde.cpp * update movement * Update boss_archimonde.cpp * Update boss_archimonde.cpp
Referenced commit(s): f78820e
…s, Yogg-Saron (azerothcore#18943) * gossip keepers, keepers, sara freya spell improvements better gossip update converter to update spellscript refactor sanity wells spawn position, summons zonecombat make sara summon sanity wells again thorim casts start again, handle sanity wells only by sanity well spawn script refactor sanity brackets update comment gossip keepers, keepers, sara freya spell improvements better gossip update converter to update spellscript refactor sanity wells spawn position, summons zonecombat make sara summon sanity wells again thorim casts start again, handle sanity wells only by sanity well spawn script refactor sanity brackets update comment gossip keepers, keepers, sara freya spell improvements better gossip update converter to update spellscript refactor sanity wells spawn position, summons zonecombat make sara summon sanity wells again thorim casts start again, handle sanity wells only by sanity well spawn script refactor sanity brackets update comment gossip keepers, keepers, sara freya spell improvements better gossip update converter to update spellscript refactor sanity wells spawn position, summons zonecombat make sara summon sanity wells again thorim casts start again, handle sanity wells only by sanity well spawn script refactor sanity brackets update comment * refactor: remove _keepersGUID[4] * make keeper auras only target players, remove apply scale immunity to well/keepers include caster in cast * update keeper flags * summon and despawn gossip keepers spawn only if fight done add intro spell and handle outro fix off by 1 fix casting simple teleport, only spawn after teleporting remove empty line * add teleport to shared ulduar.h * each keeper triggers their own gossip spawn * update is called in Reset(), no need to do it here * add SpellHit override to Freya, Hodir * Freya, Hodir: use scheduler to schedule post-fight teleport * JustSummoned rename cr to summon * sanity well summons are handled by freya instead of sara * rename pCreature to creature * keeper use RegisterUlduarCreatureAI * Freya, Hodir, Thorim: increase despawn time * despawn tentacles, sanity wells after fight despawn tentacles after fight * change order of teleport spells * am missing header?
Referenced commit(s): 845fa07
…othcore#18941) * Create oopsmybad.sql * Update oopsmybad.sql * Update oopsmybad.sql
Referenced commit(s): 88c485f
* disable_move is already set in unit_flags creature template * make kolo not selectable, disable gravity on death
AthenaSui
pushed a commit
that referenced
this pull request
Nov 28, 2024
…0642) * Felblood kael (#14) * init * initial ready version * make scheduler repeatable and correct intro sequence * some debug and OOC scheduler * Update boss_felblood_kaelthas.cpp * finale * Update boss_felblood_kaelthas.cpp * Update boss_felblood_kaelthas.cpp * Update boss_felblood_kaelthas.cpp * Update boss_felblood_kaelthas.cpp * simplify target selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.