merge #15
Merged
merge #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…available (untested)
(cherry picked from commit 642b22fb7a2c4aea5a3ce9b20765e4318f2195ce)
(cherry picked from commit 6148e797cf149e5a894578970fb214977570cfb3) # Conflicts: # data/sql/custom/db_characters/2024_05_29_00_characters_npcbot_logs.sql # data/sql/custom/db_world/2024_05_29_00_command.sql # src/server/game/AI/NpcBots/botdatamgr.cpp
(cherry picked from commit 2e6e2d8e8bcbca534cd937ce9f5ad80905829697)
…use eventmap instead (cherry picked from commit 777c8832d3b12ead931292bafc4e77881de7c863)
…gging (cherry picked from commit df0d0cb2b4c77e786ee956e9027fc6c3450d1fc3) # Conflicts: # src/server/worldserver/worldserver.conf.dist
…` log (cherry picked from commit 860433723b7439d9a01389b57870558681bbd5c9) # Conflicts: # src/server/game/AI/NpcBots/botmgr.cpp
(cherry picked from commit b421138ccbd4f6c6ca786f86f8dd02902aa561a7) # Conflicts: # src/server/game/AI/NpcBots/botmgr.cpp
…a different map id from bot's spawn map (cherry picked from commit e43c1e9969051a27ba2c4dbe05641c45a14dba0c)
AthenaSui
pushed a commit
that referenced
this pull request
Jul 30, 2024
Playerbot fixes and functionnality to talk in channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.