merge #16
Merged
merge #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Keepers (azerothcore#18949) add ancient gate emote
…othcore#18901) * add cooldown to proc * convert to spell and aurascript pair macro * remove no longer needed validate override * set cooldown with Cooldown field in table spell_proc_event
Referenced commit(s): 29dda79
…core#18945) * add insersectboundary * add kill bunny to kologarn's pit * Update data/sql/updates/pending_db_world/rev_1716571588345702920.sql Co-authored-by: Benjamin Jackson <[email protected]> * refactor: use Map DoForAllPlayers --------- Co-authored-by: Benjamin Jackson <[email protected]>
Referenced commit(s): 9900411
…re#18950) * fix the sleep visual, add stand up event * make Mimi selectable during outro so you can see his faction change * talk with emote oneshot talk * fix selectable * adjust timings * set done status when chest spawns * combat should stop when Mimiron ejects * Revert "combat should stop when Mimiron ejects" This reverts commit 6e476a5. * style
azerothcore#18956) fix(Scripts/Hyjal): Azgalor Rain of Fire should target non-player targets
* add sql * add 18850 fix * fix * Modify the commnet
Referenced commit(s): 8200385
…e#18948) * init * also talk when spell fails
Referenced commit(s): 73e4485
…not on Hit (azerothcore#18805) * Update boss_icecrown_gunship_battle.cpp Makes the Cannons on Gunship Blizzlike. They generate power (heat) on cast and not on Hit. Removes Engergize from Spell 69399 cause its only triggers on target->hit in core Still uses spellscript effect but on cast instead * Update boss_icecrown_gunship_battle.cpp
azerothcore#18960) fix(Scripts/Hyjal): Implement Eternal Silence spell when going into the Well of Eternity
Referenced commit(s): 2a1d23e
azerothcore#18900) fix(Ulduar/Tram): add rocket booster, disable logic, activate turnaround gobjects remove go_call_tram GameObjectScript add tram gobjects to header add tram logic renames update position of boosters
Referenced commit(s): 733fbf8
Referenced commit(s): fe6137b
Signed-off-by: Emmanuel Ferdman <[email protected]>
…if swimming (azerothcore#18902) * do not remove swimming auras if we are swimming * refactor to isSwimming() * Update src/server/game/Entities/Unit/Unit.cpp Co-authored-by: Andrew <[email protected]> --------- Co-authored-by: Andrew <[email protected]>
… inclined to stick close to the boss (azerothcore#18976) initial
fix(CI): try to fix ubuntu-24.04 build
…hcore#18983) this workflow currently has the warning: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ```
Referenced commit(s): 1d66487
* fix(CI): I think this fixes the labeler :D * Update labeler.yml * Update pr_labeler.yml * Update labeler.yml * test complete - this should work after merge * Update labeler.yml
azerothcore#18996) * fix(Core/Mail): calculate unReadMails and m_nextMailDelivereTime using mail cache - these values were grepped directly from DB before -> this change was introduced with azerothcore#3420 - the whole mailing system relies on the mails beeing cached in the core -> these get stored in DB regularly or on specific events - so apparently the DB is not always in sync with the current mail cache state of the core -> so grepping data directly from DB is not a good idea at this point * Update PlayerUpdates.cpp
…all death (azerothcore#18997) * init * change logic despawning of bosses is not really done the normal way, but it's forced with a set amount of guids. So we simply need to register the summons as guids as well * small fixes * Delete creature_scripts.sql * Update boss_azgalor.cpp
Referenced commit(s): a0b9423
azerothcore#19000) * fix(Script/Hyjal): Fix encounter states not reseting if bosses are despawned while in combat * Update instance_hyjal.cpp
… unit; stop the charm instead of despawning (azerothcore#18989) TrinityCore/TrinityCore@2cdea49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.