Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_nbot #24

Merged
merged 88 commits into from
Jul 6, 2024
Merged

Conversation

AthenaSui
Copy link
Owner

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

heyitsbench and others added 30 commits June 28, 2024 20:33
* fix(DB/SAI): Worg Master Kruush, Ripp & Feng

* increase range

* 20% flee for assist emote (idk)

* remove flee at 20% hp
…zerothcore#19170)

* chore(Core/DBC): Comment unused CreatureDisplayInfoExtraEntry field

* Update DBCfmt.h
…9224)

* boss_emerald_dragons spell:spell_dream_fog_sleep

* boss_emerald_dragons spell:spell_mark_of_nature
…g spree (azerothcore#19226)

* spell_rogue pair:spell_rog_killing_spree move public AddTarget up

spell_rogue pair:spell_rog_killing_spree

* fixup! spell_rogue pair:spell_rog_killing_spree
…zerothcore#18893)

Events happen at 75, 50 or 25 percent health and should not include 0%.
* fix(Core/Spells): Eye of Grillok improvements

* my eyes

* discovery of RegisterSpellAndAuraScriptPair

* comment
…core#18971)

fix(character/creation): get main part of cyrillic name
…IMINISHING_RETURNS (azerothcore#19128)

* skip other effects in case of taunt DR

* set flags_extra creature_template

TrinityCore/TrinityCore@fe38b78

Co-authored-by: offl <[email protected]>

* update query to only entries found in acore_world.creature_template

* add name as comment

* fix ci codestyle

---------

Co-authored-by: offl <[email protected]>
)

* fix(DB/SAI): Port Finding the Keymaster' RP from TDB

* .

GO spawn TrinityCore/TrinityCore@e0ccfef

Co-Authored-By: offl <[email protected]>

---------

Co-authored-by: offl <[email protected]>
Kitzunu and others added 28 commits July 4, 2024 14:30
azerothcore#19237)

fix(Core/Character): TeleportTo() in HandlePlayerLoginFromDB() causes breakdown in the network communication

* closes azerothcore#16307
…thcore#19254)

feat(Core/Spell): Implement SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT

* closes azerothcore#19248
…#19193)

* Init.

Co-Authored-By: cyberium <[email protected]>
Co-Authored-By: killerwife <[email protected]>

* Corrections.

* Adjust fear timer.

* Wrong spell.

* Whitespace.

* Use the much cooler and more hip scheduler.

* Correct teleport timers.

Matches up with sniffed 3.4.3 data.

* Swap magic number for constant.

Co-Authored-By: killerwife <[email protected]>

* Adjust notation.

* Public.

Co-authored-by: Kitzunu <[email protected]>

* Kitzunu's fault.

Co-authored-by: Kitzunu <[email protected]>

---------

Co-authored-by: cyberium <[email protected]>
Co-authored-by: killerwife <[email protected]>
Co-authored-by: Kitzunu <[email protected]>
* chore(Core/Spells): Fix compile warning

* s
…Eastern Plaguelands (azerothcore#18852)

* add sai

* Remove duplicates

* Gossip Menu 2 may only appear if Silver Dawn has reached Friendly or higher (being able to confirm that neutrality is none)
* init

* update movement

* updates and debug

* stuck :/

scheduler doesn't seem to update when at the end of wp movement???

* fix wps and implement fight

* finalise

* unused

* Update boss_nalorakk.cpp

* keep oprientation

* ran_intro
…9233)

* fix(Scripts/Shattrath): Daily Dungeon quests holographs

* Move to single script + doaction SAI

* ocd

* use NEAR_PLAYER

* use only Wind Trader as SAI

* use creature_guid target

* rename action

* cleanup

* zzz

* Update zone_shattrath_city.cpp
* scale displayInfo, cap scale to maxScale

* prevent scaling with displayInfo if scale is already increasing the size
azerothcore#19280)

fix(DB/Spells): Allow Sablemane's Sleeping Powder to bypass stun immunity
azerothcore#19281)

fix(Scripts/Item): Fix Fel Mana Potion not benefiting from Alchemist's Stone
* Init.

* Flesh out packet info.

https: //github.com/TrinityCore/TrinityCore/commit/af6d207addfef177fb5ac3e7fa61ec93ced83d16
Co-Authored-By: ForesterDev <[email protected]>

---------

Co-authored-by: ForesterDev <[email protected]>
)

* Create rev_1719945200692175000.sql

Migrate to the correct folder

* Delete data/sql/updates/pending_db_character directory

azerothcore@f96d4c8

The SQL file was placed in the wrong folder
* init

* Update SmartScript.cpp

* combatReach

* Update SmartScript.cpp
…n the same world update tick. (azerothcore#19287)

* fix(Core/Unit): Invalidate update object cache when changing health in the same world update tick.

Should fix an issue when the client sees dead NPCs when they are not.

* Fix styling

* Another codestyle fix
# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/scripts/Spells/spell_rogue.cpp
@AthenaSui AthenaSui merged commit 8942333 into AthenaSui:Az_trickerer_npcbot Jul 6, 2024
10 checks passed
AthenaSui pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.