Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_nbot #28

Merged
merged 84 commits into from
Jul 20, 2024
Merged

Conversation

AthenaSui
Copy link
Owner

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

heyitsbench and others added 30 commits July 12, 2024 19:42
azerothcore#19392)

fix(DB/Item): add flag CU_DURATION_REAL_TIME to 21174 'Empty Festive Mug'
* add Demonic Pact Aura script

TrinityCore/TrinityCore@2ff8550#diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec

Co-authored-by: ariel- <[email protected]>

* spell_warlock aura:spell_warl_demonic_pact_aura

* fixup! spell_warlock aura:spell_warl_demonic_pact_aura

* remove not needed spell correction, flag is already set

* subtract current proc bonus before calculating new bonus

* also increase healing done

* remove Demonic Pact handling in Unit

* refactor indent, remove bonus from spell group effects e.g. totem of wrath

* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"

This reverts commit 1040411.

* refactor indent

* manually set proc cooldown

---------

Co-authored-by: ariel- <[email protected]>
…thcore#19385)

* fix(DB/Creature): Time-Lost Skettis High Priest auras & SAI

https: //github.com/cmangos/tbc-db/pull/336
Co-Authored-By: AnonXS <[email protected]>

* Talonpriests

---------

Co-authored-by: AnonXS <[email protected]>
… 1 (azerothcore#19391)

* fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1

* Revert "fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1"

This reverts commit e504048.

* 39649

* spellscript

* should summon 11

* Validate
* Update zone_netherstorm.cpp

* Update zone_netherstorm.cpp

* db
…azerothcore#19402)

* fix(DB/Creature): Remove disable movement flag from Shadowy Construct

* Update rev_1720962309189833000.sql
* fix(Scripts/Commands): Ticket response

* closes azerothcore#19390

* Implements two new commands
    * ticket response delete - Delete a ticket response
    * ticket response show - Show current ticket response

* this better

* English?

* bette rlogic

* Update cs_ticket.cpp
avarishd and others added 29 commits July 17, 2024 09:09
fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK
azerothcore#19102)

* fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed

https: //github.com/TrinityCore/TrinityCore/commit/844efbfca84580f7b2bd700f40209515f2aaa959
Co-Authored-By: Shauren <[email protected]>

* ocd

* correct animation and castbar staying

---------

Co-authored-by: Shauren <[email protected]>
* fix(DB/game_event): revert squash 11.0.0 changes

- this reverts the dates in the table to COMMIT:
- f0e6b0f
- (last commit before squash 11.0.0)

* add missing ticks
* fix(Core/Spell): Allow using SpellDifficulty in bg

* cherry-pick commit (TrinityCore/TrinityCore@e4caf52)

* "Allow get SpellDifficulty on battleground maps
This is only for Isle of Conquest (Bracket 71-79 is Regular Difficulty, Bracket 80-84 is heroic or 25Man)
Spells of IoC Battleground vehicles, cannons, bombs and bosses have SpellDifficulty in DBC"

* Remove redundant CastSpell and assign a variable instead

Co-Authored-By: Gildor <[email protected]>

* Update isle_of_conquest.cpp

---------

Co-authored-by: Gildor <[email protected]>
* chore(Scripts/ChatLog): Cleanup the code

* Update chat_log.cpp

* remove more redundant code
…EWATER from some mounts (azerothcore#19431)

remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER for some mounts
…ams to enable or disable wandering bots classes and to separate it from `NpcBot.Classes.<Class>.Enable`

(cherry picked from commit 7ac1d4762b6341cd145b370a7b3b6f6a9bd89fe1)

# Conflicts:
#	src/server/worldserver/worldserver.conf.dist
…ot` command

(cherry picked from commit 5da969bd7490a1672646cc6efcf5b7591eb339e1)
(cherry picked from commit abb1be7ef7db49ee69fea0ff5136aeb3c867abc9)
…per (azerothcore#19441)

* fix(Scripts/ChatLogger): Differentiate addon whisper from player whisper

* closes azerothcore#19439
* closes azerothcore#17570

* fix build
azerothcore#19442)

chore(Github): Update issue template to further emphasize the requirement of server debug output
…re#19403)

- improve visibility of the show
- prevent glitches in the show execution
- each gameobject only exists for a very short duration, so there
  should be no relevant performance impacts
…wasn't listed when using /bonk on a bot

(cherry picked from commit b53f3c99e9d86339006ebc3f56393b6f48a1bd45)
@AthenaSui AthenaSui merged commit 5eb44c0 into AthenaSui:Az_trickerer_npcbot Jul 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.