merge #29

AthenaSui · 2024-07-20T08:54:30Z

Changes Proposed:

This PR proposes changes to:

Core (units, players, creatures, game systems).
Scripts (bosses, spell scripts, creature scripts).
Database (SAI, creatures, etc).

Issues Addressed:

Closes

SOURCE:

The changes have been validated through:

Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
Sniffs (remember to share them with the open source community!)
Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

Tested in-game by the author.
Tested in-game by other community members/someone else other than the author/has been live on production servers.
This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

This pull request can be tested by following the reproduction steps provided in the linked issue
This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

[ ]
[ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

…thcore#19395) * Init. * Whoops.

Referenced commit(s): a511ddb

…rothcore#19393) * Init. * Bad number.

Init.

azerothcore#19392) fix(DB/Item): add flag CU_DURATION_REAL_TIME to 21174 'Empty Festive Mug'

Referenced commit(s): d85d24f

* add Demonic Pact Aura script TrinityCore/TrinityCore@2ff8550#diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec Co-authored-by: ariel- <[email protected]> * spell_warlock aura:spell_warl_demonic_pact_aura * fixup! spell_warlock aura:spell_warl_demonic_pact_aura * remove not needed spell correction, flag is already set * subtract current proc bonus before calculating new bonus * also increase healing done * remove Demonic Pact handling in Unit * refactor indent, remove bonus from spell group effects e.g. totem of wrath * Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath" This reverts commit 1040411. * refactor indent * manually set proc cooldown --------- Co-authored-by: ariel- <[email protected]>

Referenced commit(s): a69d02e

…thcore#19385) * fix(DB/Creature): Time-Lost Skettis High Priest auras & SAI https: //github.com/cmangos/tbc-db/pull/336 Co-Authored-By: AnonXS <[email protected]> * Talonpriests --------- Co-authored-by: AnonXS <[email protected]>

Referenced commit(s): 0ffd5c2

Referenced commit(s): 738c365

…core#19398)

… 1 (azerothcore#19391) * fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1 * Revert "fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1" This reverts commit e504048. * 39649 * spellscript * should summon 11 * Validate

Create rev_1720906730828914400.sql

Referenced commit(s): c3d9805

)

Referenced commit(s): c164919

* Update zone_netherstorm.cpp * Update zone_netherstorm.cpp * db

Referenced commit(s): 8eb7b24

Init.

* Init. * Add `source_type`.

Referenced commit(s): 1c28456

…azerothcore#19402) * fix(DB/Creature): Remove disable movement flag from Shadowy Construct * Update rev_1720962309189833000.sql

Referenced commit(s): 9050ddc

* fix(Scripts/Commands): Ticket response * closes azerothcore#19390 * Implements two new commands * ticket response delete - Delete a ticket response * ticket response show - Show current ticket response * this better * English? * bette rlogic * Update cs_ticket.cpp

Referenced commit(s): 2008d64

…19410) Init.

Referenced commit(s): c2c2b32

Referenced commit(s): 19d1d07

* fix(DB/Import): Why did the bot fail? * nl

Referenced commit(s): be59aba

…zerothcore#19421) Create rev_1721187314824254400.sql

* Create rev_1721186384223205700.sql * Update rev_1721186384223205700.sql

Referenced commit(s): 895da2d

…#19383) * fix(Scripts/Spells): Revive pets with full mana in bgs * Pets were incorrectly revived without restoring its mana * Closes azerothcore#15894 * ready for merge --------- Co-authored-by: Saqra1 <> Co-authored-by: Kitzunu <[email protected]>

…zerothcore#19376) melee spells breaking

…zerothcore#19405) * Nefaran says low hp and shadowflame texts, use ScheduleHealthCheckEvent * use drakonic bone spells * remove no longer needed _scheduler * remove extra file

Referenced commit(s): 5674c23

…ore#19404) * fix(DB/Creature): fix spout emote text for The Lurker Below * fix(nit): add newline * Update data/sql/updates/pending_db_world/rev_1720992304054237637.sql Co-authored-by: Benjamin Jackson <[email protected]> * Update rev_1720992304054237637.sql --------- Co-authored-by: Benjamin Jackson <[email protected]> Co-authored-by: Gultask <[email protected]>

Referenced commit(s): ea00dbe

* fix(Core/Spells): Gor'drek's Ointment * Update spell_item.cpp * ;

Referenced commit(s): f510e12

fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK

azerothcore#19102) * fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed https: //github.com/TrinityCore/TrinityCore/commit/844efbfca84580f7b2bd700f40209515f2aaa959 Co-Authored-By: Shauren <[email protected]> * ocd * correct animation and castbar staying --------- Co-authored-by: Shauren <[email protected]>

* fix(DB/game_event): revert squash 11.0.0 changes - this reverts the dates in the table to COMMIT: - f0e6b0f - (last commit before squash 11.0.0) * add missing ticks

Referenced commit(s): d717f97

* fix(Core/Spell): Allow using SpellDifficulty in bg * cherry-pick commit (TrinityCore/TrinityCore@e4caf52) * "Allow get SpellDifficulty on battleground maps This is only for Isle of Conquest (Bracket 71-79 is Regular Difficulty, Bracket 80-84 is heroic or 25Man) Spells of IoC Battleground vehicles, cannons, bombs and bosses have SpellDifficulty in DBC" * Remove redundant CastSpell and assign a variable instead Co-Authored-By: Gildor <[email protected]> * Update isle_of_conquest.cpp --------- Co-authored-by: Gildor <[email protected]>

Referenced commit(s): 59766e1

* chore(Scripts/ChatLog): Cleanup the code * Update chat_log.cpp * remove more redundant code

…hcore#19434) * Init. * Reviewed changes.

…EWATER from some mounts (azerothcore#19431) remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER for some mounts

Update worldserver.conf.dist

heyitsbench and others added 30 commits July 12, 2024 19:42

fix(DB/Creature): Adjust some values of Hyjal trash creatures. (azero…

a511ddb

…thcore#19395) * Init. * Whoops.

chore(DB): import pending files

524356b

Referenced commit(s): a511ddb

fix(Scripts/HyjalSummit): Adjust Azgalor's Rain of Fire timings. (aze…

c7d0868

…rothcore#19393) * Init. * Bad number.

fix(DB/Creature): Update Hyjal boss swing timers. (azerothcore#19394)

d85d24f

Init.

fix(DB/Item): add flag CU_DURATION_REAL_TIME to 21174 'Empty Festive … (

79744df

azerothcore#19392) fix(DB/Item): add flag CU_DURATION_REAL_TIME to 21174 'Empty Festive Mug'

chore(DB): import pending files

98cb352

Referenced commit(s): d85d24f

chore(DB): import pending files

a2ca5d3

Referenced commit(s): a69d02e

chore(DB): import pending files

738c365

Referenced commit(s): 0ffd5c2

fix(DB/Conditions): Spawn only 1 'Zelfrax' (azerothcore#19365)

16e35c1

chore(DB): import pending files

758088c

Referenced commit(s): 738c365

fix(Scripts/TK): KT Mindcontrol should respect Line of Sight (azeroth…

f109768

…core#19398)

fix(DB/Creature): Rewrite Skettis mini bosses (azerothcore#19400)

d268840

Create rev_1720906730828914400.sql

chore(DB): import pending files

c164919

Referenced commit(s): c3d9805

fix(Scripts/Midsummer): correctly despawn gameobjects (azerothcore#19387

7b8e251

)

chore(DB): import pending files

5694c04

Referenced commit(s): c164919

fix(Scripts/Netherstorm): Rewrite Phase Hunter AI (azerothcore#19401)

8eb7b24

* Update zone_netherstorm.cpp * Update zone_netherstorm.cpp * db

chore(DB): import pending files

5f62cf7

Referenced commit(s): 8eb7b24

fix(Core/Unit): Adjust melee attack stop logic. (azerothcore#19397)

05f4fa1

Init.

fix(Creature): Remove bad SmartAI entries. (azerothcore#19380)

1c28456

* Init. * Add `source_type`.

chore(DB): import pending files

2a5233c

Referenced commit(s): 1c28456

fix(Scripts/ZG): Jin'do using wrong hex spell (azerothcore#19389)

e92a582

fix(DB/Creature): Remove disable movement flag from Shadowy Construct (…

9050ddc

…azerothcore#19402) * fix(DB/Creature): Remove disable movement flag from Shadowy Construct * Update rev_1720962309189833000.sql

chore(DB): import pending files

0c271cf

Referenced commit(s): 9050ddc

chore(DB): import pending files

4f4796b

Referenced commit(s): 2008d64

fix(DB/Loot): Add loot for Tenris Mirkblood event boss. (azerothcore#…

c2c2b32

…19410) Init.

chore(DB): import pending files

bdf204f

Referenced commit(s): c2c2b32

archfr and others added 28 commits July 17, 2024 01:52

fix(DB/PageText): Glyphic Scroll text (azerothcore#19114)

19d1d07

chore(DB): import pending files

bb31456

Referenced commit(s): 19d1d07

fix(DB/Import): Why did the bot fail? (azerothcore#19416)

be59aba

* fix(DB/Import): Why did the bot fail? * nl

chore(DB): import pending files

42e003e

Referenced commit(s): be59aba

fix(DB/Creature): Hellfire Training Dummies shouldn't be attackable (a…

895da2d

…zerothcore#19421) Create rev_1721187314824254400.sql

fix(DB/Creature): Small Black Temple adjustments (azerothcore#19420)

aabec7c

* Create rev_1721186384223205700.sql * Update rev_1721186384223205700.sql

chore(DB): import pending files

776dc5d

Referenced commit(s): 895da2d

fix(Core/Unit): add melee spell breaking for spells with cast time (a…

9f5b01a

…zerothcore#19376) melee spells breaking

fix(Scripts/BlackwingLair): Nefarian say low health and rewrite p3 (a…

5674c23

…zerothcore#19405) * Nefaran says low hp and shadowflame texts, use ScheduleHealthCheckEvent * use drakonic bone spells * remove no longer needed _scheduler * remove extra file

chore(DB): import pending files

498ac83

Referenced commit(s): 5674c23

chore(DB): import pending files

290482e

Referenced commit(s): ea00dbe

fix(Script/Quest): Protecting Our Own (azerothcore#19247)

f510e12

* fix(Core/Spells): Gor'drek's Ointment * Update spell_item.cpp * ;

chore(DB): import pending files

ca70459

Referenced commit(s): f510e12

fix(Core/Spell): Implement SPELL_ATTR6_NO_PUSHBACK (azerothcore#19292)

cf7c015

fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK

fix(DB/game_event): revert squash 11.0.0 changes (azerothcore#19424)

d717f97

* fix(DB/game_event): revert squash 11.0.0 changes - this reverts the dates in the table to COMMIT: - f0e6b0f - (last commit before squash 11.0.0) * add missing ticks

chore(DB): import pending files

3c77def

Referenced commit(s): d717f97

fix(DB): Correct collation for c_t_model (azerothcore#19428)

d26a2ca

chore(DB): import pending files

348dde4

Referenced commit(s): 59766e1

docs(DB): Database Squash (azerothcore#19415)

3831557

chore(Scripts/ChatLog): Cleanup the code (azerothcore#19411)

ab52e1f

* chore(Scripts/ChatLog): Cleanup the code * Update chat_log.cpp * remove more redundant code

fix(Scripts/ChatLog): Whoopsies (azerothcore#19430)

486cbb3

fix(Core): Correct packet structure for combat stop messages. (azerot…

295e4dd

…hcore#19434) * Init. * Reviewed changes.

fix(Spells/SpellInfoCorrections): remove AURA_INTERRUPT_FLAG_NOT_ABOV…

2d1e439

…EWATER from some mounts (azerothcore#19431) remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER for some mounts

Merge branch 'master' into Playerbot

22132ad

AthenaSui merged commit e4e3827 into AthenaSui:Az_lyf_Playerbot Jul 20, 2024
10 checks passed

AthenaSui pushed a commit that referenced this pull request Jan 4, 2025

Merge pull request #29 from Raz0r1337/Playerbot

e8679bc

Update worldserver.conf.dist

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge #29

merge #29

AthenaSui commented Jul 20, 2024

merge #29

merge #29

Conversation

AthenaSui commented Jul 20, 2024

Changes Proposed:

Issues Addressed:

SOURCE:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

How to Test AzerothCore PRs