Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npcbot #30

Merged
merged 24 commits into from
Jul 30, 2024
Merged

npcbot #30

merged 24 commits into from
Jul 30, 2024

Conversation

AthenaSui
Copy link
Owner

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Kitzunu and others added 24 commits July 19, 2024 19:43
* fix(DB/Creature): Ormus the Penitent

* Update rev_1721400804205047100.sql
* Config - Deprecated for 3 years
* ChatCommand - Deprecated for 2 years
* getLevel() - Deprecated for 2 years
* SendGlobalText - Deprecated for 8 years +
* fix(CI): tools

* Update tools_build.yml

* I dont think this is neccessary. Let's see if CI agrees with me
azerothcore#19455)

fix(DB/Spells): Mortal Wound and Sunder Armor stack from different casters
…19044)

* add Apprentice Morlann talk

* Modify emoticons

* fix error

* Update rev_1718007800531434000.sql

* Update data/sql/updates/pending_db_world/rev_1718007800531434000.sql

---------

Co-authored-by: Gultask <[email protected]>
* refactor(Core/Chat): PSendSysMessage to `fmt`
…rothcore#19469)

* Init.

Co-Authored-By: Tereneckla <[email protected]>

* Simplify code, add comment.

* Adjust scenario in which distance fails at all ranges.

* Remove unused variable.

* Account for deviation with distance check.

Co-Authored-By: Tereneckla <[email protected]>

* f

Co-authored-by: Kitzunu <[email protected]>

* Rewrite with initial teleport.

* Whitespace?

* Update function type.

* Drop Doomfire spawn timer.

Verified with le sniff. Teehee.

---------

Co-authored-by: Tereneckla <[email protected]>
Co-authored-by: Kitzunu <[email protected]>
@AthenaSui AthenaSui merged commit 510038f into AthenaSui:Az_trickerer_npcbot Jul 30, 2024
10 checks passed
AthenaSui pushed a commit that referenced this pull request Jan 4, 2025
Add a new statement to update character online by guid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.