pbot #31
Merged
pbot #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erothcore#19436) Create rev_1721353307227826200.sql
Referenced commit(s): d9d8ca2
…zerothcore#19435) Update boss_shade_of_akama.cpp
…erothcore#19432) * init * shadowremove * Update boss_teron_gorefiend.cpp
Referenced commit(s): 5081b0a
Referenced commit(s): 23fcd46
…per (azerothcore#19441) * fix(Scripts/ChatLogger): Differentiate addon whisper from player whisper * closes azerothcore#19439 * closes azerothcore#17570 * fix build
azerothcore#19442) chore(Github): Update issue template to further emphasize the requirement of server debug output
…re#19403) - improve visibility of the show - prevent glitches in the show execution - each gameobject only exists for a very short duration, so there should be no relevant performance impacts
* fix(DB/Creature): Ormus the Penitent * Update rev_1721400804205047100.sql
Referenced commit(s): 139e6d6
* Config - Deprecated for 3 years * ChatCommand - Deprecated for 2 years * getLevel() - Deprecated for 2 years * SendGlobalText - Deprecated for 8 years +
* fix(CI): tools * Update tools_build.yml * I dont think this is neccessary. Let's see if CI agrees with me
* daze * bruh * bruhx2
azerothcore#19455) fix(DB/Spells): Mortal Wound and Sunder Armor stack from different casters
Referenced commit(s): 1e6d0e7
…19044) * add Apprentice Morlann talk * Modify emoticons * fix error * Update rev_1718007800531434000.sql * Update data/sql/updates/pending_db_world/rev_1718007800531434000.sql --------- Co-authored-by: Gultask <[email protected]>
Referenced commit(s): c68f234
Referenced commit(s): dd8bc51
* refactor(Core/Chat): PSendSysMessage to `fmt`
Referenced commit(s): 3fbded8
…#19462) * feat(Scripts/Commands): .aurastack - Modify aura stacks * aura stack * remove aur check * {} Co-authored-by: Kitzunu <[email protected]> --------- Co-authored-by: Kitzunu <[email protected]>
Referenced commit(s): 6e0853d
…e of health (azerothcore#19479) * Update SpellAuraEffects.cpp * add comment
* elementals follow vashj * ) :)
Referenced commit(s): 6289be1
…bit (azerothcore#19418) * Update boss_supremus.cpp * Update boss_supremus.cpp * Update boss_supremus.cpp * ble * egh * ye * ermps * ok done * Update SpellInfoCorrections.cpp * Update SpellInfoCorrections.cpp
Referenced commit(s): f3c5610
…zerothcore#19463) * fix(Core/LootMgr): Improved drop checks for items that start quests to prevent unnecessary or inappropriate drops * Tweaked 2nd condition to only be valid for unique items
…9084) * init * fly :) * finally * melee attack :/ * Update zone_shadowmoon_valley.cpp Co-Authored-By: Dan <[email protected]> * Update zone_shadowmoon_valley.cpp * Update zone_shadowmoon_valley.cpp * Update zone_shadowmoon_valley.cpp --------- Co-authored-by: Dan <[email protected]>
…hcore#19408) * refactor(Core/SmartScripts): Change invoker to be WorldObject * avoid dangling else * womp womp * check for null * null check * Update SmartScript.cpp * Avarishd broke it for sure * remove redundant check * reduce more redundant code * who doesnt love redundancy
Referenced commit(s): e34ce75
…azerothcore#19450) * cherry-pick commit (TrinityCore/TrinityCore@ad96f1f) * cherry-pick commit (TrinityCore/TrinityCore@66abca1) Co-authored-by: Shauren <[email protected]>
Referenced commit(s): a9e4d3d
Playerbot fixes and functionnality to talk in channels
…core#19375) * fix(DB/SAI): Disgusting Oozeling's Dark Iron Ale interaction * keira wtf * sniff Co-Authored-By: Benjamin Jackson <[email protected]> * maxrange to 20 * change to invoker --------- Co-authored-by: Benjamin Jackson <[email protected]>
Referenced commit(s): 4c25c86
…e acore_string (azerothcore#19489) * refactor(Core/WorldSession): Make SendNotification use `fmt` * Make SendNotification use `fmt` * Make SendNotification parse acore_string entries
* fix(Scritps/AV): Use db defined text for Herald * closes azerothcore#19483 * indent * Update BattlegroundAV.cpp * fix build * remove from acore_string * Update BattlegroundAV.h
Referenced commit(s): 4785aab
…efenced. (azerothcore#19504) * Init. * Reviewed changes.
…zerothcore#19502) * Init. * Add final speeds, mark values to be changed. * Move to SQL. * Correct Thaladred's chase state.
Referenced commit(s): aa9cece
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.