pbot #37
Merged
pbot #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referenced commit(s): 7569a3b
* fix(Core/Spells): Flame Wave * ) * . flamewave faction id https://github.com/TrinityCore/TrinityCore/blame/3365e6a4b84f59cca5f7ef5fca71fb3979697e52/sql/old/9.x/world/21081_2021_10_15/2021_09_29_04_world_2018_06_17_04_world.sql#L46 Co-Authored-By: Carlos Morales <[email protected]> * lol --------- Co-authored-by: Carlos Morales <[email protected]>
Referenced commit(s): c54fd66
Fix last modification warning chat.h
azerothcore#19549) fix(Core/Spells): Chromatic Resistance Aura shouldn't give holy resistance
Referenced commit(s): 61443a4
azerothcore#19557) * Create rev_1722866773520106000.sql * Update rev_1722866773520106000.sql * Update rev_1722866773520106000.sql
Referenced commit(s): a61695f
* init * Update cs_modify.cpp * Update data/sql/updates/pending_db_world/rev_1722817302187444800.sql Co-authored-by: Benjamin Jackson <[email protected]> * Update cs_modify.cpp --------- Co-authored-by: Benjamin Jackson <[email protected]>
Referenced commit(s): a23da06
* fix(Scripts/Hyjal): Anetheron dont sleep main tank * Update boss_anetheron.cpp
…#19561) * init * Update boss_mother_shahraz.cpp * Update boss_mother_shahraz.cpp * Update boss_mother_shahraz.cpp * Update boss_mother_shahraz.cpp
…zerothcore#19563) * Init values. * Convert to queries. * Consolidate.
Referenced commit(s): c59effe
* Update zone_shadowmoon_valley.cpp * Update zone_shadowmoon_valley.cpp
…zerothcore#19490) * refactor(Core/World): Move SendGMText to WorldSession and allow `fmt` - Move SendGMText from World to WorldSession - Make SendGMText use fmt - Make SendGMText parse acore_string entries * Update cs_message.cpp * tokenize the string only once * Move to chathandler * Update WorldSession.cpp * make sure we have a session
Referenced commit(s): bb7765d
…#19491) * refactor(Core/Chat): Move SendNotification to ChatHander * Update Battleground.cpp * fix build * Update src/server/game/Chat/Chat.h
azerothcore#19585) * refactor(Core/ChatHandler): Cleanup retriving session and checking for valid session * redundant * make it clear what a "valid" session is * HasValidSession -> HasSession * Differentiate from "valid" which in this case would mean the player is in world which isnt checked here
…t working properly (azerothcore#19593) fix(Core/Chat): Correct misstake in b81bcfb causing outputs to CLI not working properly * closes azerothcore#19592
Revert "chore(Script/Misc): cleanup (azerothcore#19619)" This reverts commit 7ff8f72.
* move several enum definitions in a new files * move more things * remove the include comment * move the related code to CharmInfo in this own file *original idea of Ovahlord Co-Authored-By: Ovahlord <[email protected]> * fix clang build errors and few blank lines * missing forward declaration * new tentative to fix gcc/clang build * add several include could be necessary for gcc/clang compilation * . * revert some include since the last AC update * fix some loop inconsistencies * align all enums in UnitDefine.h --------- Co-authored-by: Ovahlord <[email protected]>
…e#19622 (azerothcore#19633) * fix(Core/Entities): crash fix cause by a pointer change in azerothcore#19622 * fix blank space for codestyle check
* fix(CI/MacOS): Try to fix macOS mysql setup. * Update ci-compile.sh * More debug code * Mooooore debug * Moooooorreee * Moooooooooooorereerererer * m o r e debug * more debug * more * More debug * 9.0.1.reinstall??? we already had mysql? * debug * Debug * Are we happy now? * No? And what about now?! * Adn now? * Yes, we are happy 😎
Referenced commit(s): 4d2284c
Referenced commit(s): 29f528c
…19642) fix(DB/Creature): Remove Veras stun immunity
Referenced commit(s): 682c053
Installer output is wrong for BSD*. "acore.sh install-deps" says "This platform is not supported" should be "BSD is not supported yet"
…ardian summons. (azerothcore#19664) Revert "fix(Core/Spells): Adjust ownership and follow logic for guardian summ…" This reverts commit cc2ef9d.
…#19669) * fix(Core/Creature): Nullcheck for questgreeting greeting * closes azerothcore#19659 * Update GossipDef.cpp
azerothcore#19674) fix(Script/Vehicles): The next player entering Salvaged Siege Engine should control turret if it's not occupied.
Referenced commit(s): b0f77eb
… spells that target enemies (azerothcore#19529) remove object size for aoe on enemy spells
…f Justice on random players (azerothcore#19653) * fix: SelectTargetMethod Random replaced with MaxThreat * restore like origin * fix: cast Hammer Of Justice on current target instead random target * refactor: case EVENT_SPELL_HAMMER_OF_JUSTICE statement refactored * refactor: if statement splitted * refactor: last space removed * Update src/server/scripts/Outland/BlackTemple/illidari_council.cpp Co-authored-by: Benjamin Jackson <[email protected]> * fix redundant check and new line --------- Co-authored-by: MattiaBallarini <[email protected]> Co-authored-by: Andrew <[email protected]> Co-authored-by: Benjamin Jackson <[email protected]>
Referenced commit(s): cccd800
* chore(Core/Misc): Use HasNpcFlag instead of HasFlag * extend to all npcflag helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.