nbot #38
Merged
nbot #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referenced commit(s): 4d2284c
Referenced commit(s): 29f528c
…19642) fix(DB/Creature): Remove Veras stun immunity
Referenced commit(s): 682c053
Installer output is wrong for BSD*. "acore.sh install-deps" says "This platform is not supported" should be "BSD is not supported yet"
…ardian summons. (azerothcore#19664) Revert "fix(Core/Spells): Adjust ownership and follow logic for guardian summ…" This reverts commit cc2ef9d.
…#19669) * fix(Core/Creature): Nullcheck for questgreeting greeting * closes azerothcore#19659 * Update GossipDef.cpp
azerothcore#19674) fix(Script/Vehicles): The next player entering Salvaged Siege Engine should control turret if it's not occupied.
Referenced commit(s): b0f77eb
… spells that target enemies (azerothcore#19529) remove object size for aoe on enemy spells
…f Justice on random players (azerothcore#19653) * fix: SelectTargetMethod Random replaced with MaxThreat * restore like origin * fix: cast Hammer Of Justice on current target instead random target * refactor: case EVENT_SPELL_HAMMER_OF_JUSTICE statement refactored * refactor: if statement splitted * refactor: last space removed * Update src/server/scripts/Outland/BlackTemple/illidari_council.cpp Co-authored-by: Benjamin Jackson <[email protected]> * fix redundant check and new line --------- Co-authored-by: MattiaBallarini <[email protected]> Co-authored-by: Andrew <[email protected]> Co-authored-by: Benjamin Jackson <[email protected]>
Referenced commit(s): cccd800
* chore(Core/Misc): Use HasNpcFlag instead of HasFlag * extend to all npcflag helpers
When a pet ability was cast, PetHandler reset all CharmInfo flags before calling PetAI methods, setting the attack flag to true every time. This commands the pet to go and chase the target which is not correct when the state is COMMAND_STAY. PetAI already handles the scenario, it just wasn't getting the actual pet attack state.
* fix(DB/SAI): Hemathion spells and timers * correct the devour spell cast condition * forget to delete the old devour line
Referenced commit(s): 9d76ec6
…erothcore#19686) * Init. * Add additional sniffed values. * Add damage modifier default.
Referenced commit(s): 0d0b0a3
* Fix it not being cast if no valid targets are available * Apply Patch 2.2 nerfs
Referenced commit(s): 82db308
…ipts (azerothcore#19643) * chore(Debug/Scripting): improve debug errors during script unloading * add the script name to increase debug informations and ensure to derefence script pointers
Referenced commit(s): 7932130
…othcore#19675) * Use DoForAllPlayers * Change to void - we don't need to return a value * Better readability
…re#19636) * fix(Scripts/SethekkHalls): Prevent multiple spawns of Anzu * Update instance_sethekk_halls.cpp * Update instance_sethekk_halls.cpp * Update rev_1723763212128826500.sql
Referenced commit(s): dd41692
added deeprun rat roundup fix for smartscripts
Referenced commit(s): 497d1ac
Update Spell.cpp
azerothcore#19702) * fix(Core/WorldSocketMgr): sync default Network.OutUBuff with worldserver.conf.dist * Update WorldSocketMgr.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.