nbot #45
Merged
nbot #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of Azzinoth (azerothcore#19967) fix(Scripts/Core): fix blaze and flame bast casting for Flame of Azzinoth
…azerothcore#19948) * fix(Scripts/BlackTemple): fix stationary shadow demons * optimization: use else if to stop the execution when a condition is reach * revert last changes and fix the spell to allow move while casting * .
azerothcore#19944) * fix(Scripts/BlackTemple): Parasitic Shadowfiends should not target players affected with debuff * Update boss_illidan.cpp * Update src/server/scripts/Outland/BlackTemple/boss_illidan.cpp * make it simple
azerothcore#19946) * fix(Scripts/BlackTemple): Implement emotes when opening Najentus and Den of Mortal Delights * only check if state is done
Referenced commit(s): 8b16f7d
…9975) * fix(Scripts/BT): correct illidari council enrage timer * wrong conversion from azerothcore@5ae1473 * redundant
azerothcore#19962) * fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMASTER_COUNT - this allows flagging quests so that they will not count towards Loremaster achievement - update Corrupted Flower Quests in Felwood accordingly as a first use case * load Specialflags as uint32 from DB
Referenced commit(s): e2353a1
Referenced commit(s): 07c54fe
…zerothcore#19968) fix(Scripts/BlackTemple): fix the charge mechanic of Flames of Azzinoth * remove also a old duplicate check in a spell script
…t. (azerothcore#19991) * Revert "fix(Core/Spells): Revert triggered spell logic change. (azerothcore#19983)" This reverts commit 3bb5ec7. * Add aura effect check. Co-Authored-By: Anton Popovichenko <[email protected]> * Add comment, use target instead of owner. * Adjust comment terminology. --------- Co-authored-by: Anton Popovichenko <[email protected]>
Try to fix bug with loot
…ng (azerothcore#19957) * fix(DB/Creature) Black Temple - Illidari Assassin: Riposte ability missing * fix(DB/Creature): Black Temple - Illidari Assassin: Riposte ability missing * Update 2024_09_13_00.sql * bitwise method
Referenced commit(s): 1d899cf
… version. (azerothcore#19997) * fix(CI/MacOS): Fix MacOS CI dependency installation. * Try to use macos 14 version * Remove brew cleanup and z3 dependency * Adjust readline lib discovery * Update macos supported version in SECURITY.md
…sage (azerothcore#19926) * fix lance requirement error msg * ;
Referenced commit(s): 188b864
* remove weird blanks * update if * ) ) to )) * missed some ) ) * now switch * .
* fix(Core/AllMapScript) Update structure to use CALL_ENABLED_HOOKS * fatal error: no template named 'vector' in namespace 'std' * fix build Co-authored-by: Anton Popovichenko <[email protected]> --------- Co-authored-by: Anton Popovichenko <[email protected]>
azerothcore#20012) fix(Scripts/Commands): Prevent crash if you use doublequotes in go creature name * closes azerothcore#20010
* fix(DB/Creature) Ebon Blade Commander Equipment * fix(DB/Creature) Ebon Blade Commander Equipment * Update rev_1725226115559982400.sql * Update rev_1725226115559982400.sql ---------
…azerothcore#20004) * Init. * Correct wrong query characters.
* fix(Scripts/Quest): Fires Over Skettis * Update spell_item.cpp ---------
Referenced commit(s): 511235c
azerothcore#20021) fix(Scripts/BlackTemple): Fix Fatal Attraction not being removed if targets move apart
…rothcore#20013) * refactor(Core/Database): improve abort messages for mysql errors * Update MySQLConnection.cpp
Referenced commit(s): d0178bb
…zerothcore#19987) * add sql add boats remove vehicle_seat_addon stuff Co-authored-by: Dr-J <[email protected]> * update smartAI comments with Keira3 * fix sql, make summoners invisible to players * change spellId 62011 to 'Romantic' 69352 * Update rev_1725993194571320983.sql --------- Co-authored-by: Dr-J <[email protected]> Co-authored-by: sudlud <[email protected]>
Referenced commit(s): d6c731f
…t item for offline loot owner. (azerothcore#20033)
…veTakeoff (azerothcore#20005) Co-authored-by: killerwife <[email protected]>
Referenced commit(s): a7578e1
azerothcore#20036) fix(Scripts/BlackTemple): Correct the door announcement to only announce on the first bosses
Referenced commit(s): a65be25
* refactor(SQL/Quest) Rescuing the Rescuers ID 11244 * fix range and max targets * Texts are added and the smart_script list is modified Co-authored-by: DEV Seaferer <[email protected]> --------- Co-authored-by: DEV Seaferer <[email protected]>
Referenced commit(s): 891bcd8
…A_USE_OFFHAND_ATTACK, creature disarm damage (azerothcore#20015) * enable CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK * sql set CREATURE_FLAG_EXTRA_USE_OFFHAND * use new HasOffHandWeaponForAttack instead of haveOffhandWeapon no longer requires m_CanDualwield set to use Offhand attack requires non-disarmed weapon in Offhand OR creature_flag_extra enabled Co-authored-by: Ovah <[email protected]> Co-authored-by: Warlockbugs <[email protected]> * Make shapeshift forms which dont override attack speed use weapon damage Co-authored-by: killerwife <[email protected]> * SetEquipmentSlots turning off damage update when using template default Co-authored-by: killerwife <[email protected]> * Setup DualWield & Damage On Equipment Updates, implement Set and GetVirtualItem Co-authored-by: Yatzii <[email protected]> * creature disarm damage set disarm to reduce minmax damage by 50% instead of setting to 0 Co-authored-by: Warlockbugs <[email protected]> --------- Co-authored-by: Ovah <[email protected]> Co-authored-by: Warlockbugs <[email protected]> Co-authored-by: killerwife <[email protected]> Co-authored-by: Yatzii <[email protected]>
Referenced commit(s): 6e4a9bb
Referenced commit(s): 52b8fa1
* non-weapons should return true * remove shapeshift check
Referenced commit(s): 3504273
Co-authored-by: Álvaro Martín <[email protected]>
Referenced commit(s): 3dc47ee
…othcore#20039) * new BattlegroundDesertionTypes for hook OnBattlegroundDesertion * chore: minor improvements --------- Co-authored-by: laasker <[email protected]>
# Conflicts: # src/server/game/Entities/Creature/CreatureData.h # src/server/game/Entities/Unit/StatSystem.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.