fix for bots trying to mount in WSG and AV tunnels

AthenaSui · Aug 15, 2024 · f87c87f · f87c87f
1 parent 780934a
commit f87c87f
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/strategy/actions/CheckMountStateAction.cpp b/src/strategy/actions/CheckMountStateAction.cpp
@@ -129,11 +129,14 @@ bool CheckMountStateAction::isUseful()
     if (bot->isDead())
         return false;
 
-    bool isOutdoor = bot->IsOutdoors();
-    if (!isOutdoor)
+    if (bot->HasUnitState(UNIT_STATE_IN_FLIGHT))
         return false;
 
-    if (bot->HasUnitState(UNIT_STATE_IN_FLIGHT))
+    // checks both outdoors flag, and whether bot is clipping below floor slightly
+    // because that will cause bot to falsely indicate outdoors state and try
+    // mount indoors (seems to mostly be an issue in tunnels of WSG and AV)
+    if (!bot->IsOutdoors() || bot->GetPositionZ() < bot->GetMapWaterOrGroundLevel(
+                                                        bot->GetPositionX(), bot->GetPositionY(), bot->GetPositionZ()))
         return false;
 
     if (bot->InArena())