Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up options and meta on uninstall #1134

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

obenland
Copy link
Member

@obenland obenland commented Jan 7, 2025

Proposed changes:

  • Adds removals for registered user and post meta, as well as options to the uninstall hook.

Is there more data that we add, that should be removed here?

@obenland obenland requested a review from a team January 7, 2025 21:57
@obenland obenland self-assigned this Jan 7, 2025
@pfefferle
Copy link
Member

I like to cleanup in general, but this is very destructive and might cause some data loss by accident, even more because it was different before!

What about adding a consent layer when the user clicks the remove link or adding a "remove and delete all data" link?

@obenland
Copy link
Member Author

might cause some data loss by accident, even more because it was different before!

This only runs when the plugin gets deleted, not when it's deactivated.
With it being different than before, do you mean that it now deletes data where it didn't use to?

What about adding a consent layer when the user clicks the remove link or adding a "remove and delete all data" link?

Core has a built-in "Are You Sure" modal when you try to delete a plugin.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants