-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Implement the initial product category menu using a standardized side-scrolling behavior. #98153
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
0a8a0ab
to
f544d16
Compare
91c559f
to
63cb8cb
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~436 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
f544d16
to
5dc0d70
Compare
421fe7b
to
375334b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty neat - lgtm 🚀
<Icon icon={ chevronRight } size={ 20 } /> | ||
</Button> | ||
</div> | ||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be cool to allow the content to be scrolled by swiping on mobile screens. Just an idea for later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is good suggestion. I'll add a low-prio ticket to address this. 👍
5dc0d70
to
92cc682
Compare
37d4f5e
to
0b51b3c
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17193310 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @jkguidaven, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Looks great James |
@jkguidaven looking good! Just leaving a note for the details to tweak (transition timing) later on: |
This PR introduces a working carousel menu on the new Products page. Just so you know, the menu items are placeholders and will be replaced with actual items in a separate PR.
We want this PR to focus exclusively on the Carousel element and the scroll-down behavior.
Screen.Recording.2025-01-09.at.11.18.23.PM.mov
Depends on #98086
Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1636
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist