Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (#39) Add evm contracts #44

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

OT-kraftchain
Copy link
Member

No description provided.

@OT-kraftchain OT-kraftchain requested a review from mialbu December 4, 2024 10:26
@OT-kraftchain OT-kraftchain force-pushed the feat/#39_add_evm_contracts branch from 29cdbda to 778778d Compare December 4, 2024 10:33
@OT-kraftchain
Copy link
Member Author

@mialbu it looks like the java tests have been failing on develop as well. I'd rather fix them in a separate PR just with that purpose, but if you prefer, I can try to fix them in this one

@gsmachado
Copy link
Member

@OT-kraftchain can you please update the README.md? Thanks.

Copy link
Member

@mialbu mialbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments/questions

hardhat.config.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@OT-kraftchain OT-kraftchain force-pushed the feat/#39_add_evm_contracts branch from bc04eaf to 8393f6b Compare December 4, 2024 19:17
@OT-kraftchain OT-kraftchain requested a review from mialbu December 4, 2024 19:21
Copy link
Member

@mialbu mialbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion you could commit or leave, up to you - then let's go 💯

README.md Outdated Show resolved Hide resolved
@OT-kraftchain OT-kraftchain requested a review from mialbu December 5, 2024 11:53
@OT-kraftchain OT-kraftchain merged commit 9969990 into develop Dec 10, 2024
1 check failed
@OT-kraftchain OT-kraftchain deleted the feat/#39_add_evm_contracts branch December 10, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants