Add support for h264 signed code type 6 SEI #1064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for h264 signed videos
steabert
reviewed
Jan 7, 2025
steabert
reviewed
Jan 7, 2025
| nalType: type, | ||
| } | ||
| this._buffer = Buffer.alloc(0) | ||
| h264Debug(`got a SEI type`) |
There was a problem hiding this comment.
Do you happen to have an RFC or other reference docs about this NAL type?
There was a problem hiding this comment.
Hi!
Yes FRC3984 describes the SEI types, section 4.1, here the link:
https://www.ietf.org/rfc/rfc3984.txt
The main referencia IMHO is our Axis repository for "Signed Video Framework"
https://github.com/AxisCommunications/signed-video-framework/blob/master/README.md
BR, José
Update parser.ts to add SEI type 6 to NAL_TYPES at the top folling indication from Steabert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1061
Provide a general description of your change in the PR title:
Checklist for review