Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streams): capture MP4 stream #1080

Merged
merged 1 commit into from
Jan 11, 2025
Merged

feat(streams): capture MP4 stream #1080

merged 1 commit into from
Jan 11, 2025

Conversation

steabert
Copy link
Member

Adds a capture method to the pipelines that produce MP4 data. It stores all data in a buffer at start of movie, and passes it to the provided callback when capture ends. The latter can be triggered by calling the returned trigger function, or automatically when the buffer is full.

Checklist for review

  • PR title and description are clear
  • change follows existing coding style and architecture
  • necessary unit tests were added
  • documentation was updated

@steabert steabert requested review from Tigge and rikteg as code owners January 11, 2025 08:51
Adds a `capture` method to the pipelines that produce MP4 data.
It stores all data in a buffer at start of movie, and passes it to
the provided callback when capture ends. The latter can be triggered
by calling the returned trigger function, or automatically when the
buffer is full.

Co-authored-by: Rikard Tegnander <[email protected]>
Co-authored-by: Victor Ingvarsson <[email protected]>
@steabert steabert merged commit 74eb3a1 into main Jan 11, 2025
8 checks passed
@steabert steabert deleted the stevenv/mp4capture branch January 11, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant