chore!: combine into single media-stream-library package
#1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steabert
force-pushed
the
release-esm
branch
5 times, most recently
from
97a70fb to
666c869
Compare
Moves the overlay, player, and streams modules into the media-stream-library package, but as separate exports. This simplifies package management and moves the two smaller related packages into the main package. Improves to the way releases work: - Always have the package version changed when any changes are made to the source, and add a verification for this (housekeeping job). - Release using a workflow trigger, takes the package as it is and creates both a GitHub release and publishes to NPM, using the version already contained in the source. - Keep the minified bundle that includes the dependencies outside of the dist folder (thereby excluding it from the NPM package). Since that bundle is only needed outside of a package system, and then we don't need to export it separately. BREAKING CHANGES: - `media-overlay-library` and `media-stream-player` packages are no longer provided, they are now available from `media-stream-library/overlay` and `media-stream-library/player` respectively. - The format of the minified bundles is changed from IIFE to ES module, since this now has baseline support across all modern browsers. Together these changes allow for simple release flow, where we can just pick latest main for releases, where the correct version is already part of source control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the overlay, player, and streams modules into the media-stream-library package, but as separate exports. This simplifies package management and moves the two smaller related packages into the main package.
Improves to the way releases work:
BREAKING CHANGES:
media-overlay-libraryandmedia-stream-playerpackages are no longer provided, they are now available frommedia-stream-library/overlayandmedia-stream-library/playerrespectively.Together these changes allow for simple release flow, where we can just pick latest main for releases, where the correct version is already part of source control.
Checklist for review