fix: put sources under a single TypeScript config #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steabert
force-pushed
the
single-tsconfig
branch
2 times, most recently
from
b03dfa1 to
4bf2124
Compare
Internal imports should be resolve relatively (i.e. player should not import from the package itself). The simplest way is to further group all sources, and use a single TypeScript configuration. With code-splitting enabled, the result is essentially the same.
steabert
force-pushed
the
single-tsconfig
branch
from
4bf2124 to
c490c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal imports should be resolve relatively (i.e. player should not import from the package itself). The simplest way is to further group all sources, and use a single TypeScript configuration. With code-splitting enabled, the result is essentially the same.
Checklist for review