Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename package name to @azure-maps/gridded-data-source #5

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Rename package name to @azure-maps/gridded-data-source #5

merged 3 commits into from
Sep 9, 2024

Conversation

zhz0704
Copy link
Collaborator

@zhz0704 zhz0704 commented Sep 5, 2024

No description provided.

@zhz0704 zhz0704 requested a review from dubiety September 5, 2024 08:55
yulinscottkang
yulinscottkang reviewed Sep 9, 2024
View reviewed changes
Copy link

@yulinscottkang yulinscottkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: update the SDK version to support both v2 & v3

"dependencies": {
-   "azure-maps-control": "^3.3.0"
+   "azure-maps-control": "^2.0.25 || ^3.0.1"
}

@dubiety dubiety merged commit 8978fa4 into Azure-Samples:main Sep 9, 2024
5 checks passed
@zhz0704 zhz0704 deleted the change-package-name branch October 23, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubiety dubiety dubiety approved these changes

@yulinscottkang yulinscottkang yulinscottkang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhz0704 @yulinscottkang @dubiety