Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix something wrong in index.html template #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix something wrong in index.html template #58

wants to merge 2 commits into from

Conversation

issei-m
Copy link

@issei-m issei-m commented Aug 3, 2020

  • Fix some syntax errors of HTML
  • Remove useless JavaScript code
  • Fix indent

@issei-m
Fix something wrong in index.html template
e52dd52 
- Fix some syntax errors of HTML
- Remove useless JavaScript code
- Fix indent
@issei-m
Copy link
Author

issei-m commented Sep 10, 2020

ping @zr-msft since you seem to be a person who made the latest merge commit.
If you had the time to review it, please see it.
Regards.

@Point-SimoSiren
Copy link

ping @issei-m Hello, this interesting tutorial. I tried to change names other than purple and blue, and app doesnt work anymore. I wonder is it really so that app can handle only dog, cat and blue, purple ? Another question is that why you have left button onClick(send) handlers if u removed the script? I have seen input type submit but is this send similar inside form?

@issei-m
Copy link
Author

issei-m commented Oct 2, 2020

I'll take it on this weekend :)

@issei-m
Copy link
Author

issei-m commented Oct 3, 2020 •
edited
Loading

@Point-SimoSiren I could rename the caption of the buttons by updating config_file.cfg where the captions of them are defined, so try it on.
image

And leaving the onclick handlers was just my mistake, I fixed it, Thanks pointing out it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issei-m @Point-SimoSiren