-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fortinet FortiGate WebSession Parsers Parsing Fix & Additions #10865
base: master
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
Hi @t-pol, |
Hi @t-pol, |
The issues have been fixed. Thanks |
Thanks @t-pol. |
Hello, is there any feedback regarding the parser ? |
can you please add tester files after testing |
Hi @t-pol, please check above comments from @Alekhya0824 and act accordingly. Thanks |
Hi @t-pol, |
Hi @t-pol, |
Hi @t-pol, |
Hi @t-pol, |
Hi @t-pol, |
Hello, |
@t-pol Thankyou for your updates. Can we try below?
|
Changes have been applied. |
Hi @t-pol, |
Hi @t-pol, |
Hello @v-atulyadav , I have fixed the pending issues. Please proceed and check the pr. |
Hello @v-atulyadav @vakohl , I have fixed the pending issues. Please proceed and check the pr. |
Required items, please complete
Change(s):
Reason for Change(s):
When there is no User Agent string in AdditionalExtensions, the parsing of HttpRequestMethod fails.
![300977692-5147bab0-35b3-4861-9610-7e0ece0a3628](https://private-user-images.githubusercontent.com/24976309/351639461-5bd7077d-2d91-490f-a404-2f73796cb08f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODE4MDgsIm5iZiI6MTczOTE4MTUwOCwicGF0aCI6Ii8yNDk3NjMwOS8zNTE2Mzk0NjEtNWJkNzA3N2QtMmQ5MS00OTBmLWE0MDQtMmY3Mzc5NmNiMDhmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA5NTgyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgyODA5OGMwNjIwM2Q0ZmFiOGUyMGM0NWIwZDY5N2E5YTY4YTlkYzkyNzQ5MDA4NDMzNDFhMjlmMjZiOTQ4OGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.W4gjm7z3kIdEqOHTE_bqqI-4RSiozRkKL5EktSP7eVM)
Incorrect parsing of HttpRequestMethod and HttpUserAgent.
Adding NetworkApplicationProtocol field in the project-rename. (Optional field in the parser, but it exists in FortiGate logs)
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: