Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial SAP etd release #11722

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

MartinPankraz
Copy link
Contributor

Required items, please complete

Change(s):

  • Release of SAP ETD solution

Reason for Change(s):

  • Initial release

@v-prasadboke v-prasadboke self-assigned this Jan 28, 2025
@v-prasadboke v-prasadboke added the New Solution For new Solutions which are new to Microsoft Sentinel label Jan 28, 2025
@v-prasadboke
Copy link
Contributor

Hello @MartinPankraz, Please package the solution again with version 3.0.0

@MartinPankraz MartinPankraz marked this pull request as ready for review January 28, 2025 14:09
@MartinPankraz MartinPankraz requested review from a team as code owners January 28, 2025 14:09
@v-prasadboke
Copy link
Contributor

Hello @MartinPankraz, Looks like you accidentally removed the Connector and Detection file. Can you please add those back

@MartinPankraz
Copy link
Contributor Author

Hello @MartinPankraz, Looks like you accidentally removed the Connector and Detection file. Can you please add those back

Hey @v-prasadboke the solution is complete on the mainTemplate.json only (connector and detections). The other folders and files are empty. Dropped them for clarity.

@v-prasadboke
Copy link
Contributor

Hello @MartinPankraz,

These files are required in the Solution folder and cannot be removed. They are necessary for future use and may be essential as the solution evolves or for upcoming integrations.

@MartinPankraz
Copy link
Contributor Author

@v-prasadboke changes done as per your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Solution For new Solutions which are new to Microsoft Sentinel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants