Skip to content

Commit

Permalink
update build base image (#1660)
Browse files Browse the repository at this point in the history
  • Loading branch information
akshaysngupta authored Nov 9, 2024
1 parent 7172d8f commit 054590f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG BUILDPLATFORM=linux/amd64
ARG BUILD_BASE_IMAGE
ARG BINARY_BASE_IMAGE
ARG BUILD_BASE_IMAGE=golang:1.23.3
ARG BINARY_BASE_IMAGE=ubuntu:22.04

FROM --platform=$BUILDPLATFORM $BUILD_BASE_IMAGE AS build
WORKDIR /azure
Expand Down
12 changes: 11 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ GO_BINARY_NAME ?= appgw-ingress
GOOS ?= linux
GARCH ?= arm64

BUILD_BASE_IMAGE ?= golang:1.22.5-bookworm
BUILD_BASE_IMAGE ?= golang:1.23.3
BINARY_BASE_IMAGE ?= ubuntu:22.04

REPO ?= appgwreg.azurecr.io
Expand Down Expand Up @@ -65,6 +65,16 @@ build-image-multi-arch:
$(IMAGE_TAGS) \
$(shell pwd)

build-image:
@docker build \
--build-arg "BUILD_BASE_IMAGE=$(BUILD_BASE_IMAGE)" \
--build-arg "BINARY_BASE_IMAGE=$(BINARY_BASE_IMAGE)" \
--build-arg "BUILD_TAG=$(BUILD_TAG)" \
--build-arg "BUILD_DATE=$(BUILD_DATE)" \
--build-arg "GIT_HASH=$(GIT_HASH)" \
$(IMAGE_TAGS) \
$(shell pwd)

build:
go build -mod=readonly -v -ldflags="$(GO_LDFLAGS)" -v -o ./bin/${GO_BINARY_NAME} ./cmd/appgw-ingress

Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/Azure/application-gateway-kubernetes-ingress

go 1.22.0
go 1.23.0

toolchain go1.22.4
toolchain go1.23.3

require (
github.com/Azure/azure-sdk-for-go v66.0.0+incompatible
Expand Down

0 comments on commit 054590f

Please sign in to comment.