Refactor msbuild props and targets #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
requested review from
vrdmr,
gavin-aguiar,
YunchuWang,
pdthummar,
hallvictoria and
a team
as code owners
liliankasem
approved these changes
Dec 4, 2024
jviau
commented
Dec 4, 2024
liliankasem
reviewed
Dec 4, 2024
liliankasem
reviewed
Dec 4, 2024
liliankasem
approved these changes
Dec 4, 2024
jviau
force-pushed
the
jviau/eng/props
branch
from
03c6985 to
90c9f6d
Compare
kshyju
reviewed
Dec 10, 2024
kshyju
reviewed
Dec 10, 2024
test/DotNetIsolatedUnsupportedWorker/DotNetIsolatedUnsupportedWorker.csproj
Show resolved
Hide resolved
kshyju
approved these changes
Dec 10, 2024
gavin-aguiar
approved these changes
Dec 18, 2024
jviau
added a commit
that referenced
this pull request
Jan 10, 2025
* Address versioning and public release * Adjust tag link in release notes * resources -> res * Clean up props and versioning * Remove buildNumber from CI files * Remove initialize pipeline stage * Run test in parallel * Skip readme if not present * Fix missing Version.targets import * Bring back tools PublicKey.snk * Comment out tests for now * Re-add delaysign * TreatWarningAsError=false for ExtensionMetadataGenerator * Re-enable tests * Move 'UpdateBuildNumber' * Fix spelling * Remove old python.props code owners entry * Remove Placeholder configurations, replace with props file * Re-add AllowUnsafeBlocks * Build DotnetIsolatedPlaceholder projects as p2p ref * Private=false for test resource projects * RunAnalyzers=false for DotnetIsolated test apps * Revert Private=false change for TestFunctions * Revert other test app ref changes * Use property for placeholder simulation * Fix Targets -> Target * Fix indentation * Add Build.Counter variable
jviau
added a commit
that referenced
this pull request
Jan 14, 2025
* Refactor msbuild props and targets (#10664) * Address versioning and public release * Adjust tag link in release notes * resources -> res * Clean up props and versioning * Remove buildNumber from CI files * Remove initialize pipeline stage * Run test in parallel * Skip readme if not present * Fix missing Version.targets import * Bring back tools PublicKey.snk * Comment out tests for now * Re-add delaysign * TreatWarningAsError=false for ExtensionMetadataGenerator * Re-enable tests * Move 'UpdateBuildNumber' * Fix spelling * Remove old python.props code owners entry * Remove Placeholder configurations, replace with props file * Re-add AllowUnsafeBlocks * Build DotnetIsolatedPlaceholder projects as p2p ref * Private=false for test resource projects * RunAnalyzers=false for DotnetIsolated test apps * Revert Private=false change for TestFunctions * Revert other test app ref changes * Use property for placeholder simulation * Fix Targets -> Target * Fix indentation * Add Build.Counter variable * Fix sit ext template * Remove ExtensionMetadataGenerator from in-proc branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
This PR refactors our msbuild targets & props.
build/and spreading that logic around ineng/build.Directory.Version.propsfile.devfor local,prfor PR builds,cifor all other non-release CI builds. eg:4.38.0-dev.24306.0for a local build.initialize-pipeline.ymlstage removed as it is no longer needed (this work is not done directly in msbuild)DotnetIsolated*.csprojprojects now built as a direct dependency of integration test project (and not in the test itself).NullReferenceExceptionfrom AspNetCore analyzerRegistrationExpectedInASPNetIntegrationazure-functions-dotnet-worker#2888) with our aspnetcore worker analyzers. Disabled analyzers to unblock the build.