Port OpenRewrite to Main #43884
Open
Port OpenRewrite to Main #43884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srnagar
reviewed
Jan 22, 2025
sdk/tools/azure-openrewrite/src/main/java/com/azure/recipes/AddTryCatchToMethodCallRecipe.java
Outdated
Show resolved
Hide resolved
sdk/tools/azure-openrewrite/src/main/java/com/azure/recipes/AddTryCatchToMethodCallRecipe.java
Outdated
Show resolved
Hide resolved
sdk/tools/azure-openrewrite/src/main/java/com/azure/recipes/RemoveFixedDelayRecipe.java
Outdated
Show resolved
Hide resolved
sdk/tools/azure-openrewrite/src/main/java/com/azure/recipes/RemoveFixedDelayRecipe.java
Outdated
Show resolved
Hide resolved
jairmyree
requested review from
alzimmermsft,
g2vinay,
rujche,
Netyyyy,
saragluna and
moarychan
as code owners
...ols/azure-openrewrite/src/main/java/com/azure/openrewrite/AddTryCatchToMethodCallRecipe.java
Outdated
Show resolved
Hide resolved
sdk/tools/azure-openrewrite/src/main/resources/META-INF/rewrite/rewrite.yml
Show resolved
Hide resolved
sdk/tools/azure-openrewrite/src/main/resources/META-INF/rewrite/rewrite.yml
Show resolved
Hide resolved
sdk/tools/azure-openrewrite/src/main/resources/META-INF/rewrite/rewrite.yml
Show resolved
Hide resolved
...ols/azure-openrewrite/src/main/java/com/azure/openrewrite/AddTryCatchToMethodCallRecipe.java
Show resolved
Hide resolved
...ols/azure-openrewrite/src/main/java/com/azure/openrewrite/AddTryCatchToMethodCallRecipe.java
Outdated
Show resolved
Hide resolved
samvaity
reviewed
Jan 23, 2025
srnagar
reviewed
Jan 23, 2025
...ols/azure-openrewrite/src/main/java/com/azure/openrewrite/AddTryCatchToMethodCallRecipe.java
Show resolved
Hide resolved
...ols/azure-openrewrite/src/main/java/com/azure/openrewrite/AddTryCatchToMethodCallRecipe.java
Outdated
Show resolved
Hide resolved
...ols/azure-openrewrite/src/main/java/com/azure/openrewrite/AddTryCatchToMethodCallRecipe.java
Show resolved
Hide resolved
srnagar
approved these changes
Jan 23, 2025
eng/versioning/version_client.txt
Outdated
| @@ -484,6 +484,7 @@ io.clientcore:core;1.0.0-beta.1;1.0.0-beta.2 | |||
| io.clientcore:http-okhttp3;1.0.0-beta.1;1.0.0-beta.1 | |||
| io.clientcore:http-stress;1.0.0-beta.1;1.0.0-beta.1 | |||
| io.clientcore:optional-dependency-tests;1.0.0-beta.1;1.0.0-beta.1 | |||
| com.azure:azure-openrewrite;1.0.0-beta.1;1.0.0-beta.1 | |||
There was a problem hiding this comment.
nit: add this with the rest of the com.azure packages sorted alphabetically.
sdk/tools/azure-openrewrite/pom.xml
Outdated
Comment on lines
39
to
46
| <!-- You only need the version that corresponds to your current | ||
| Java version. It is fine to add all of them, though, as | ||
| they can coexist on a classpath. --> | ||
| <dependency> | ||
| <groupId>org.openrewrite</groupId> | ||
| <artifactId>rewrite-java-17</artifactId> | ||
| <scope>runtime</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Does this mean we should have dependencies for all versions ranging from 8 to 23 because user apps could be on any of these versions?
|
@srnagar I will further confirm but I believe this dependency is necessary for developing recipes, not running them. So, we would only need the one that supports our Java baseline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the work done within the azure/azsdk-java-rewrite-recipes in this repository for continued development of Azure OpenRewrite