Skip to content

Commit

Permalink
Fix bug where obj.AzureName was not used to create Azure URLs (#4516)
Browse files Browse the repository at this point in the history
obj.Name was mistakenly used when it should have been obj.AzureName (or
id.Name, which is derived from the ARM ID which comes from
obj.AzureName).

Fixes #4515.
  • Loading branch information
matthchr authored Jan 7, 2025
1 parent bf95590 commit 674b3f8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (ext *NamespacesEventhubsAuthorizationRuleExtension) ExportKubernetesSecret
return nil, eris.Wrapf(err, "failed to create new EventHubsClient")
}

res, err = confClient.ListKeys(ctx, id.ResourceGroupName, id.Parent.Parent.Name, id.Parent.Name, typedObj.Name, nil)
res, err = confClient.ListKeys(ctx, id.ResourceGroupName, id.Parent.Parent.Name, id.Parent.Name, id.Name, nil)
if err != nil {
return nil, eris.Wrapf(err, "failed to retreive response")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (ext *NamespacesAuthorizationRuleExtension) ExportKubernetesSecrets(

client := clientFactory.NewNamespacesClient()
options := armservicebus.NamespacesClientListKeysOptions{}
response, err := client.ListKeys(ctx, id.ResourceGroupName, namespaceID.Name, rule.Name, &options)
response, err := client.ListKeys(ctx, id.ResourceGroupName, namespaceID.Name, id.Name, &options)
if err != nil {
return nil, eris.Wrapf(
err,
Expand Down

0 comments on commit 674b3f8

Please sign in to comment.