Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIM Backend, NamedValue and Subscription #3376

Merged
merged 26 commits into from
Oct 10, 2023

Conversation

ross-p-smith
Copy link
Contributor

@ross-p-smith ross-p-smith commented Oct 4, 2023

Relates to #2747 and builds on #3368

This is the 2nd APIM Pull Request that adds Backend / NamedValue and Subscription. These are simple types

gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #3376 (ee44d66) into main (c267abd) will decrease coverage by 0.03%.
The diff coverage is 52.08%.

@@            Coverage Diff             @@
##             main    #3376      +/-   ##
==========================================
- Coverage   54.49%   54.46%   -0.03%     
==========================================
  Files        1515     1527      +12     
  Lines      636546   639467    +2921     
==========================================
+ Hits       346855   348264    +1409     
- Misses     233033   234363    +1330     
- Partials    56658    56840     +182     
Files Coverage Δ
...ment/customizations/backend_extension_types_gen.go 100.00% <100.00%> (ø)
.../customizations/named_value_extension_types_gen.go 100.00% <100.00%> (ø)
...customizations/subscription_extension_types_gen.go 100.00% <100.00%> (ø)
...i/apimanagement/v1api20220801/backend_types_gen.go 41.88% <ø> (ø)
...i/apimanagement/v1api20220801/service_types_gen.go 50.71% <ø> (ø)
...nagement/v1api20220801storage/service_types_gen.go 52.72% <ø> (ø)
...1api20220801/service_backend_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...20220801/service_named_value_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...0220801/service_subscription_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...2/internal/controllers/controller_resources_gen.go 84.02% <82.02%> (-0.10%) ⬇️
... and 5 more

... and 31 files with indirect coverage changes

@matthchr
Copy link
Member

matthchr commented Oct 4, 2023

/ok-to-test sha=f547a5d

Copy link
Collaborator

@super-harsh super-harsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up PR for adding additional APIM resources. I've left a few minor comments on marking properties secret or armReferences, the rest all looks pretty solid to me. :)

v2/api/apimanagement/v1api20220801/structure.txt Outdated Show resolved Hide resolved
v2/api/apimanagement/v1api20220801/structure.txt Outdated Show resolved Hide resolved
v2/api/apimanagement/v1api20220801/structure.txt Outdated Show resolved Hide resolved
@theunrepentantgeek
Copy link
Member

I've had a quick skim and agree with @super-harsh - this is looking very good. I'll give it a proper review early next week.

@matthchr
Copy link
Member

/ok-to-test sha=ca3a423

tc.CreateResourceAndWait(&service)

tc.Expect(service.Status.Id).ToNot(BeNil())
// TODO: When you are debugging, you can use this to create the APIM service once and not delete it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to use CreateResourceAndWait and not the Untracked variants once your final PR is merged.

@matthchr
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matthchr matthchr merged commit ad74e05 into Azure:main Oct 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants