-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIM Backend, NamedValue and Subscription #3376
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3376 +/- ##
==========================================
- Coverage 54.49% 54.46% -0.03%
==========================================
Files 1515 1527 +12
Lines 636546 639467 +2921
==========================================
+ Hits 346855 348264 +1409
- Misses 233033 234363 +1330
- Partials 56658 56840 +182
|
/ok-to-test sha=f547a5d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up PR for adding additional APIM resources. I've left a few minor comments on marking properties secret or armReferences, the rest all looks pretty solid to me. :)
I've had a quick skim and agree with @super-harsh - this is looking very good. I'll give it a proper review early next week. |
keys should be secrets
/ok-to-test sha=ca3a423 |
tc.CreateResourceAndWait(&service) | ||
|
||
tc.Expect(service.Status.Id).ToNot(BeNil()) | ||
// TODO: When you are debugging, you can use this to create the APIM service once and not delete it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to use CreateResourceAndWait
and not the Untracked
variants once your final PR is merged.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Relates to #2747 and builds on #3368
This is the 2nd APIM Pull Request that adds
Backend
/NamedValue
andSubscription
. These are simple typesIf applicable: